New issue
Advanced search Search tips

Issue 658393 link

Starred by 11 users

Issue metadata

Status: Duplicate
Merged: issue 64062
Owner: ----
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Allow streaming for in-progress downloads

Project Member Reported by agamble@google.com, Oct 21 2016

Issue description

Chrome Version       : Version 54.0.2840.71 m (64-bit)
URLs (if applicable) :
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari: PASS/FAIL (Version)
    Firefox: PASS/FAIL (Version)
         IE: PASS/FAIL (Version)

What steps will reproduce the problem?
(1) Start a video file download
(2) Open in-progress video .crdownload file in VLC or other media player
(3) Download finishes while .crdownload file is being played.

What is the expected result?
Video continues playing. .crdownload file remains.


What happens instead?
Video abruptly stops. .crdownload file is removed. Download starts over from the beginning.


Please provide any additional information below. Attach a screenshot if
possible.

Users reporting this behavior here:
https://productforums.google.com/forum/#!topic/chrome/jQrxCz_Eplg
https://productforums.google.com/forum/#!msg/chrome/n8JqBz5Q2_I/W85Ve8PeBAAJ

The change in behavior seems to have been introduced when 'automatic download resumption' was enabled.

 

Comment 1 by asanka@chromium.org, Oct 21 2016

Components: UI>Browser>Downloads UI>Browser>SafeBrowsing
Labels: -OS-Windows -Type-Bug OS-All Type-Feature
Status: Available (was: Unconfirmed)
Summary: Allow streaming for in-progress downloads (was: Automatic download resumption restarts download if file is open when download finishes)
We haven't supported opening intermediate files or otherwise interfering with an ongoing download. This is especially the case where the download finalization steps include safe browsing checks. However, it seems users are doing so anyway. So we'll need to treat this as a valid use case and make it safer to do so.

We could (for a set of whitelisted file types which are known to be safe for streaming):

* Front load some of the SB checks are that currently put off until the download completes. URL and host based checks can be performed at the start of the download.

* Perform the final rename early.

* Avoid the download content check, which would be a no-op.

* Allow invoking 'Open' while the download is in progress instead of only allowing open after download completion.

This would effectively open up these file types for streaming safely.

+SafeBrowsing as well to evaluate this suggestion.

I moved the resumption behavior into another bug:  Issue 658412
For file types we think aren't dangerous, it seems reasonable to do url/host checks up front and call it safe.  But if we need the content digest to check its safety, we'd need to let it complete first.

Comment 3 by asanka@chromium.org, Oct 24 2016

#2: Yup. I was thinking something like the allow_auto_open setting which would whitelist a set of file types to be streamed.

We can even go to a point where the initial URL safety check can return something like "need-content-digest" that would block the file from being streamed. This can happen on a per file basis in case we want to look at the URL chain prior to making a call on whether the file is safe for streaming.

Perhaps we can chat about this later this week since it involves non-trivial backend work.

Comment 4 by asanka@chromium.org, Oct 31 2016

Cc: cblume@chromium.org
 Issue 660737  has been merged into this issue.
Mergedinto: 64062
Status: Duplicate (was: Available)
Ah. Merging with older issue.

Sign in to add a comment