Disable multiadvertising until we support multi-signal strength |
||||||||
Issue descriptionSee also Issue 658385 CTS Verifier is fail in M54/M55 because we does not support setting signal strength per each advertisement slot and we can't get waiver for this. We should disable multi-advertising for now.
,
Oct 21 2016
SGTM, Approved for 55, we do probably want (need for CTS) this in 54 also, but I will let Josafat flip that bit.
,
Oct 22 2016
,
Oct 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4438f8fe974c55d1d8c4f515feab9763aad2b530 commit 4438f8fe974c55d1d8c4f515feab9763aad2b530 Author: puthik <puthik@chromium.org> Date: Sat Oct 22 02:49:55 2016 arc: bluetooth: Set advertisement max slot to 1 CTS Verifier want us to also support multiple signal strength when we declared that multi-advertisement is supported. Disable multiadvertisement until that is done. BUG= 658387 ,658385 TEST=CTS Verifier LE signal strength test won't show up Review-Url: https://chromiumcodereview.appspot.com/2438373002 Cr-Commit-Position: refs/heads/master@{#426958} [modify] https://crrev.com/4438f8fe974c55d1d8c4f515feab9763aad2b530/components/arc/bluetooth/arc_bluetooth_bridge.h [modify] https://crrev.com/4438f8fe974c55d1d8c4f515feab9763aad2b530/components/arc/bluetooth/arc_bluetooth_bridge_unittest.cc
,
Oct 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c82de058b24a0bf58d9303ea06e884f7f49af87 commit 1c82de058b24a0bf58d9303ea06e884f7f49af87 Author: Elijah Taylor <elijahtaylor@google.com> Date: Sat Oct 22 04:10:00 2016 arc: bluetooth: Set advertisement max slot to 1 CTS Verifier want us to also support multiple signal strength when we declared that multi-advertisement is supported. Disable multiadvertisement until that is done. BUG= 658387 ,658385 TEST=CTS Verifier LE signal strength test won't show up Review-Url: https://chromiumcodereview.appspot.com/2438373002 Cr-Commit-Position: refs/heads/master@{#426958} (cherry picked from commit 4438f8fe974c55d1d8c4f515feab9763aad2b530) Review URL: https://codereview.chromium.org/2442133003 . Cr-Commit-Position: refs/branch-heads/2883@{#236} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/1c82de058b24a0bf58d9303ea06e884f7f49af87/components/arc/bluetooth/arc_bluetooth_bridge.h [modify] https://crrev.com/1c82de058b24a0bf58d9303ea06e884f7f49af87/components/arc/bluetooth/arc_bluetooth_bridge_unittest.cc
,
Oct 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/debab5eebcaf1650dbca02fc1a8702fa41ea41ce commit debab5eebcaf1650dbca02fc1a8702fa41ea41ce Author: Elijah Taylor <elijahtaylor@google.com> Date: Sat Oct 22 04:44:39 2016 [M54] arc: bluetooth: Set advertisement max slot to 1 CTS Verifier want us to also support multiple signal strength when we declared that multi-advertisement is supported. Disable multiadvertisement until that is done. BUG= 658387 , 658385 TEST=CTS Verifier LE signal strength test won't show up (spiritual cherry-pick of 4438f8fe974c55d1d8c4f515feab9763aad2b530) R=puthik@chromium.org Review URL: https://codereview.chromium.org/2444673002 . Cr-Commit-Position: refs/branch-heads/2840@{#768} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/debab5eebcaf1650dbca02fc1a8702fa41ea41ce/components/arc/bluetooth/arc_bluetooth_bridge.cc
,
Oct 24 2016
BT Multiadvertising is now disabled in M54/M55 Rohit, can you confirm on 8743.72.0+?
,
Oct 24 2016
Thanks. We will have CTS-V results by tomorrow.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c82de058b24a0bf58d9303ea06e884f7f49af87 commit 1c82de058b24a0bf58d9303ea06e884f7f49af87 Author: Elijah Taylor <elijahtaylor@google.com> Date: Sat Oct 22 04:10:00 2016 arc: bluetooth: Set advertisement max slot to 1 CTS Verifier want us to also support multiple signal strength when we declared that multi-advertisement is supported. Disable multiadvertisement until that is done. BUG= 658387 ,658385 TEST=CTS Verifier LE signal strength test won't show up Review-Url: https://chromiumcodereview.appspot.com/2438373002 Cr-Commit-Position: refs/heads/master@{#426958} (cherry picked from commit 4438f8fe974c55d1d8c4f515feab9763aad2b530) Review URL: https://codereview.chromium.org/2442133003 . Cr-Commit-Position: refs/branch-heads/2883@{#236} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/1c82de058b24a0bf58d9303ea06e884f7f49af87/components/arc/bluetooth/arc_bluetooth_bridge.h [modify] https://crrev.com/1c82de058b24a0bf58d9303ea06e884f7f49af87/components/arc/bluetooth/arc_bluetooth_bridge_unittest.cc
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/debab5eebcaf1650dbca02fc1a8702fa41ea41ce commit debab5eebcaf1650dbca02fc1a8702fa41ea41ce Author: Elijah Taylor <elijahtaylor@google.com> Date: Sat Oct 22 04:44:39 2016 [M54] arc: bluetooth: Set advertisement max slot to 1 CTS Verifier want us to also support multiple signal strength when we declared that multi-advertisement is supported. Disable multiadvertisement until that is done. BUG= 658387 , 658385 TEST=CTS Verifier LE signal strength test won't show up (spiritual cherry-pick of 4438f8fe974c55d1d8c4f515feab9763aad2b530) R=puthik@chromium.org Review URL: https://codereview.chromium.org/2444673002 . Cr-Commit-Position: refs/branch-heads/2840@{#768} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/debab5eebcaf1650dbca02fc1a8702fa41ea41ce/components/arc/bluetooth/arc_bluetooth_bridge.cc
,
Oct 28 2016
,
Dec 14 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by puthik@chromium.org
, Oct 21 2016Labels: Merge-Request-54 Merge-Request-55