New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 658372 link

Starred by 3 users
Status: Assigned
Owner:
sgabr...@chromium.org
Cc:
█ yoshiki@chromium.org
tbuck...@chromium.org
█ tdander...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

ash toasts need to be update for MD

Project Member Reported by est...@chromium.org, Oct 21 2016 
from reading the code, it appears that ash toasts attempt to use some form of MD.[1] The buttons, for example, use ink drops, medium weight font, and shouty text ("DISMISS"). They should be using MdTextButton instead. The rest of the toast would probably benefit from Sebastien review as well.

[1] https://cs.chromium.org/chromium/src/ash/common/system/toast/toast_overlay.cc?rcl=1477021054&l=113

Comment 1 by tbuck...@chromium.org, Oct 24 2016

Components: Design
Labels: -M-56
These seem reasonably well materialized, so not a blocker for M56. I agree they should be reviewed.

Comment 2 by sgabr...@chromium.org, Oct 25 2016 

Not sure what I should be looking at. Do we have a screenshot of this ? I only see code :)

Comment 3 by est...@chromium.org, Oct 25 2016 

I just know where the code is. I don't know how to exercise the toasts, but maybe Tom does?

Comment 4 by tdander...@chromium.org, Mar 7 2017

Labels: Hotlist-Poachable

Comment 5 by est...@chromium.org, May 31 2017

Cc: tbuck...@chromium.org
+tbuckley, do you know how to display toasts?
►

Sign in to add a comment