New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 658368 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Mojo: packaged "all user" services don't work

Project Member Reported by jcivelli@chromium.org, Oct 21 2016

Issue description

If an "all user" (singleton) service is packaged inside another service, it fails to start (the service manager tries to start it as if was not packaged).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dcec2d180e56dcfe84506daac08ef37d7d57a24

commit 8dcec2d180e56dcfe84506daac08ef37d7d57a24
Author: jcivelli <jcivelli@chromium.org>
Date: Thu Oct 27 18:54:23 2016

Make sure an "all user" service works when packaged as part of another
service:
- Use the empty string as instance id when none provided instead of the
  service name.
- Disable the tracing service by default.
- changed the ServiceManagerListener.OnServiceStarted notification so it
  is fired when the service has replied (instead of when the process is
  created)
- introduced a ServiceManagerListener notification for when a service
  was not started
- added a new instance_per_child flag to service_manager to control
  whether a new process should be created when starting a new
  packaged service

BUG= 658368 
TEST=ServiceManagerTest.CreatePackagedSingletonInstance

Review-Url: https://codereview.chromium.org/2440903002
Cr-Commit-Position: refs/heads/master@{#428098}

[modify] https://crrev.com/8dcec2d180e56dcfe84506daac08ef37d7d57a24/chrome/app/mash/chrome_mash_manifest.json
[modify] https://crrev.com/8dcec2d180e56dcfe84506daac08ef37d7d57a24/chrome/test/base/mash_browser_tests_manifest.json
[modify] https://crrev.com/8dcec2d180e56dcfe84506daac08ef37d7d57a24/mash/task_viewer/task_viewer.cc
[modify] https://crrev.com/8dcec2d180e56dcfe84506daac08ef37d7d57a24/services/catalog/entry.cc
[modify] https://crrev.com/8dcec2d180e56dcfe84506daac08ef37d7d57a24/services/service_manager/public/cpp/lib/identity.cc
[modify] https://crrev.com/8dcec2d180e56dcfe84506daac08ef37d7d57a24/services/service_manager/public/interfaces/resolver.mojom
[modify] https://crrev.com/8dcec2d180e56dcfe84506daac08ef37d7d57a24/services/service_manager/public/interfaces/service_manager.mojom
[modify] https://crrev.com/8dcec2d180e56dcfe84506daac08ef37d7d57a24/services/service_manager/service_manager.cc
[modify] https://crrev.com/8dcec2d180e56dcfe84506daac08ef37d7d57a24/services/service_manager/service_manager.h
[modify] https://crrev.com/8dcec2d180e56dcfe84506daac08ef37d7d57a24/services/service_manager/standalone/context.cc
[modify] https://crrev.com/8dcec2d180e56dcfe84506daac08ef37d7d57a24/services/service_manager/switches.cc
[modify] https://crrev.com/8dcec2d180e56dcfe84506daac08ef37d7d57a24/services/service_manager/switches.h
[modify] https://crrev.com/8dcec2d180e56dcfe84506daac08ef37d7d57a24/services/service_manager/tests/connect/connect_unittest.cc
[modify] https://crrev.com/8dcec2d180e56dcfe84506daac08ef37d7d57a24/services/service_manager/tests/lifecycle/lifecycle_unittest.cc
[modify] https://crrev.com/8dcec2d180e56dcfe84506daac08ef37d7d57a24/services/service_manager/tests/service_manager/BUILD.gn
[add] https://crrev.com/8dcec2d180e56dcfe84506daac08ef37d7d57a24/services/service_manager/tests/service_manager/embedder.cc
[add] https://crrev.com/8dcec2d180e56dcfe84506daac08ef37d7d57a24/services/service_manager/tests/service_manager/embedder_manifest.json
[modify] https://crrev.com/8dcec2d180e56dcfe84506daac08ef37d7d57a24/services/service_manager/tests/service_manager/service_manager_unittest.cc
[modify] https://crrev.com/8dcec2d180e56dcfe84506daac08ef37d7d57a24/services/service_manager/tests/service_manager/service_manager_unittest_manifest.json
[add] https://crrev.com/8dcec2d180e56dcfe84506daac08ef37d7d57a24/services/service_manager/tests/service_manager/singleton_manifest.json

Status: Fixed (was: Untriaged)

Sign in to add a comment