New issue
Advanced search Search tips

Issue 658364 link

Starred by 2 users
Status: Fixed
Owner:
lizeb@chromium.org
Closed: Oct 2016
Cc:
yus...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

StrictMode violation in mayLaunchUrl

Project Member Reported by lizeb@chromium.org, Oct 21 2016 
From a Google-internal report:

10-21 12:56:03.039  5853  5853 D StrictMode: StrictMode policy violation; ~duration=9 ms: android.os.StrictMode$StrictModeDiskReadViolation: policy=4522015 violation=2
10-21 12:56:03.039  5853  5853 D StrictMode:    at android.os.StrictMode$AndroidBlockGuardPolicy.onReadFromDisk(StrictMode.java:1293)
10-21 12:56:03.039  5853  5853 D StrictMode:    at java.io.UnixFileSystem.checkAccess(UnixFileSystem.java:249)
10-21 12:56:03.039  5853  5853 D StrictMode:    at java.io.File.exists(File.java:780)
10-21 12:56:03.039  5853  5853 D StrictMode:    at android.app.ContextImpl.ensurePrivateDirExists(ContextImpl.java:512)
10-21 12:56:03.039  5853  5853 D StrictMode:    at android.app.ContextImpl.getPreferencesDir(ContextImpl.java:468)
10-21 12:56:03.039  5853  5853 D StrictMode:    at android.app.ContextImpl.getSharedPreferencesPath(ContextImpl.java:627)
10-21 12:56:03.039  5853  5853 D StrictMode:    at android.app.ContextImpl.getSharedPreferences(ContextImpl.java:345)
10-21 12:56:03.039  5853  5853 D StrictMode:    at android.content.ContextWrapper.getSharedPreferences(ContextWrapper.java:164)
10-21 12:56:03.039  5853  5853 D StrictMode:    at org.chromium.chrome.browser.customtabs.RequestThrottler.purgeOldEntries(RequestThrottler.java:211)
10-21 12:56:03.039  5853  5853 D StrictMode:    at org.chromium.chrome.browser.customtabs.RequestThrottler.getForUid(RequestThrottler.java:130)
10-21 12:56:03.039  5853  5853 D StrictMode:    at org.chromium.chrome.browser.customtabs.ClientManager.updateStatsAndReturnWhetherAllowed(ClientManager.java:147)
10-21 12:56:03.039  5853  5853 D StrictMode:    at org.chromium.chrome.browser.customtabs.CustomTabsConnection.mayLaunchUrlInternal(CustomTabsConnection.java:328)
10-21 12:56:03.039  5853  5853 D StrictMode:    at org.chromium.chrome.browser.customtabs.CustomTabsConnection.mayLaunchUrl(CustomTabsConnection.java:307)
10-21 12:56:03.039  5853  5853 D StrictMode:    at org.chromium.chrome.browser.customtabs.CustomTabsConnectionService.mayLaunchUrl(CustomTabsConnectionService.java:54)
10-21 12:56:03.039  5853  5853 D StrictMode:    at android.support.customtabs.CustomTabsService$1.mayLaunchUrl(CustomTabsService.java:85)
10-21 12:56:03.039  5853  5853 D StrictMode:    at android.support.customtabs.ICustomTabsService$Stub.onTransact(ICustomTabsService.java:90)
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1581f7287c88b91ba1bb964ae644917eba76758e

commit 1581f7287c88b91ba1bb964ae644917eba76758e
Author: lizeb <lizeb@chromium.org>
Date: Wed Oct 26 18:56:11 2016

customtabs: Access the throttling shared preferences from warmup().

This is to suppress StrictMode violations (and remove latency) from
mayLaunchUrl().

BUG= 658364 

Review-Url: https://codereview.chromium.org/2435403002
Cr-Commit-Position: refs/heads/master@{#427767}

[modify] https://crrev.com/1581f7287c88b91ba1bb964ae644917eba76758e/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

Comment 2 by lizeb@chromium.org, Oct 27 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment