New issue
Advanced search Search tips

Issue 658355 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 610428
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 630357



Sign in to add a comment

Collected cookies dialog contents should be scrollable when needed

Project Member Reported by shrike@chromium.org, Oct 21 2016

Issue description

Version: 56.0.2896.3
OS: Win 10

What steps will reproduce the problem?
(1) Bring up the collected cookies dialog

The screenshot shows the result of tabbing around in the dialog - the blue line near the bottom of the dialog is a selected textfield which is not visible because of the dialog's size. Perhaps Windows constrains dialogs based on the height of the screen.

This isn't happening on the Mac. I'm not sure about CrOS or Linux.

 
CookiesDialogButtons.png
81.0 KB View Download
Labels: -Pri-2 Pri-1
Owner: kylixrd@chromium.org
Status: Assigned (was: Available)
Summary: Harmony - dialog contents should always be scrollable in overflow (was: Harmony - cookies dialog controls hidden on 2x Windows screen)
There may be a more general problem here where all Harmony dialogs' "content areas" need to get a scrollbar if their content exceeds the allocated height.

Some dialogs (e.g. JS alerts) are specced as being limited to a particular height, while others (like this one) are not, but even in the latter case, there will be instances where the screen resolution is low, or the window is placed low on the screen, or for some other reason the total window height gets clamped.  This implies we shouldn't just one-off fix this for "dialogs likely to be tall", we should fix it in a common way across all Harmony dialogs.

So, probably, all Harmony dialogs need a structure like:
[ Title area ]
[ Scroll view that parents all content ]
[ Bottom set of buttons ]

I thought DialogDelegate/DialogClientView/something already provided a structure like this, but it's been a long time since I've worked with them and I didn't see anything about scrolling in either one, so it's not immediately clear to me what we need to add where.

Allen, I'm kicking this to you to investigate, since it's more in the nature of "broader architecture/delegate question".
Cc: pkasting@chromium.org
The CollectedCookiesDialog is a little more complicated than many of the other DialogDelegateView implementations. The main client area has several sections which interact; the upper tabbed area which has two listview/treeview "tabs" and associated buttons. The lower pane show the information. It is this lower section which should be scrolled independently rather than the whole top-level client area.

The solution would be to use a ScrollView class to wrap the lower pane into a scrollable area.
SGTM
I'm trying to figure out under what circumstances this will happen. The CookieInfoView() is sized to include all labels. As of right now, this is how it looks.
CollectedCookiesViewMD.png
21.2 KB View Download
Cc: ellyjo...@chromium.org
Summary: Collected cookies dialog contents should be scrollable when needed (was: Harmony - dialog contents should always be scrollable in overflow)
It sounds from comment 2 like we're scoping this as being about this specific dialog, and while there may be a few other specific dialogs that also want to be scrollable, the solutions should be per-dialog and not global.

Given that, should this be duped against bug 610428, the general bug on this dialog?
Labels: -M-58
Mergedinto: 610428
Status: Duplicate (was: Assigned)

Sign in to add a comment