New issue
Advanced search Search tips

Issue 658347 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 571470



Sign in to add a comment

Record the number of days since data saver is ON

Project Member Reported by tbansal@chromium.org, Oct 21 2016

Issue description

Currently, if a user turns off the data saver, their HTTP traffic is not proxied, and they do not receive any compression benefits. However, the data saver prefs that record the daily content lengths (original and compressed) are still incremented for every HTTP request. So, if the user turns on data saver in future at some point, they will have a large number of original and compressed bytes, but very little savings. This can cause confusion if the user visits the data saver settings page to look at the savings.

To see how frequently this happens, we should record the number of days since data saver is ON in UMA. This will also help in debugging some of the user feedback reports (e.g., low savings in https://bugs.chromium.org/p/chromium/issues/detail?id=571470#c25 could be because of user turning off data saver at some point in the past).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/579a409d89d9da9a10a924e3d4704fc1e1144d77

commit 579a409d89d9da9a10a924e3d4704fc1e1144d77
Author: tbansal <tbansal@chromium.org>
Date: Tue Oct 25 15:52:16 2016

Record UMA on number of days since data reduction proxy is enabled.

BUG= 658347 

Review-Url: https://codereview.chromium.org/2439303002
Cr-Commit-Position: refs/heads/master@{#427368}

[modify] https://crrev.com/579a409d89d9da9a10a924e3d4704fc1e1144d77/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc
[modify] https://crrev.com/579a409d89d9da9a10a924e3d4704fc1e1144d77/components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs.cc
[modify] https://crrev.com/579a409d89d9da9a10a924e3d4704fc1e1144d77/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc
[modify] https://crrev.com/579a409d89d9da9a10a924e3d4704fc1e1144d77/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
[modify] https://crrev.com/579a409d89d9da9a10a924e3d4704fc1e1144d77/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc
[modify] https://crrev.com/579a409d89d9da9a10a924e3d4704fc1e1144d77/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h
[modify] https://crrev.com/579a409d89d9da9a10a924e3d4704fc1e1144d77/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
[modify] https://crrev.com/579a409d89d9da9a10a924e3d4704fc1e1144d77/components/data_reduction_proxy/core/common/data_reduction_proxy_pref_names.cc
[modify] https://crrev.com/579a409d89d9da9a10a924e3d4704fc1e1144d77/components/data_reduction_proxy/core/common/data_reduction_proxy_pref_names.h
[modify] https://crrev.com/579a409d89d9da9a10a924e3d4704fc1e1144d77/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Sign in to add a comment