Only show profiles that have a street address in Payment Request shipping address. |
|||||||||
Issue descriptionRight now, they are only suggested after complete profiles. But if the incomplete profile has no street address, it should not be suggested at all.
,
Oct 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6efc8643cafe5e3825ae422b4a12f2197633cf7 commit d6efc8643cafe5e3825ae422b4a12f2197633cf7 Author: sebsg <sebsg@chromium.org> Date: Fri Oct 21 21:20:12 2016 [Payments] Don't suggest profiles with no street address in PR. BUG= 658346 Review-Url: https://chromiumcodereview.appspot.com/2438343002 Cr-Commit-Position: refs/heads/master@{#426890} [modify] https://crrev.com/d6efc8643cafe5e3825ae422b4a12f2197633cf7/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [modify] https://crrev.com/d6efc8643cafe5e3825ae422b4a12f2197633cf7/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingMultipleAddressesTest.java
,
Oct 24 2016
,
Oct 24 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Oct 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25558a8ea4c25435487fd984b553a207da5b58ae commit 25558a8ea4c25435487fd984b553a207da5b58ae Author: sebsg <sebsg@chromium.org> Date: Mon Oct 24 22:11:02 2016 [Payments] Don't suggest profiles with no street address in PR. BUG= 658346 Review-Url: https://chromiumcodereview.appspot.com/2438343002 Cr-Commit-Position: refs/heads/master@{#426890} (cherry picked from commit d6efc8643cafe5e3825ae422b4a12f2197633cf7) Review URL: https://codereview.chromium.org/2448653003 . Cr-Commit-Position: refs/branch-heads/2883@{#269} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/25558a8ea4c25435487fd984b553a207da5b58ae/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [modify] https://crrev.com/25558a8ea4c25435487fd984b553a207da5b58ae/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingMultipleAddressesTest.java
,
Oct 24 2016
,
Oct 26 2016
Incomplete profiles are not listed in the payment request shipping address. Hence closing the issue as fixed in current M55 build 55.0.2883.28
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25558a8ea4c25435487fd984b553a207da5b58ae commit 25558a8ea4c25435487fd984b553a207da5b58ae Author: sebsg <sebsg@chromium.org> Date: Mon Oct 24 22:11:02 2016 [Payments] Don't suggest profiles with no street address in PR. BUG= 658346 Review-Url: https://chromiumcodereview.appspot.com/2438343002 Cr-Commit-Position: refs/heads/master@{#426890} (cherry picked from commit d6efc8643cafe5e3825ae422b4a12f2197633cf7) Review URL: https://codereview.chromium.org/2448653003 . Cr-Commit-Position: refs/branch-heads/2883@{#269} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/25558a8ea4c25435487fd984b553a207da5b58ae/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [modify] https://crrev.com/25558a8ea4c25435487fd984b553a207da5b58ae/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingMultipleAddressesTest.java
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Jun 27 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by se...@chromium.org
, Oct 21 2016