New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 658329 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 672651
Owner: ----
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove or replace PrettyPatch.rb.

Project Member Reported by qyears...@chromium.org, Oct 21 2016

Issue description

I was just looking at PrettyPatch, and wondering whether we'll want to replace it at some point (with a Python script, or with some some third party module).

I think the main advantage of replacing it is to enable pretty patches to be generated when running run-webkit-tests even if ruby isn't installed ( bug 620270 ). Also, some parts of PrettyPatch.rb may be unnecessary now, e.g. there are references to SVN in that file.

Dirk, I remember at one point you mentioned that we could rework the way that diffs are made -- do you remember what you were thinking?


 
I think I was thinking that we could replace one or both of PrettyPatch and wdiff with Python code written on top of difflib.

I think cleaning this stuff up is low priority but worthwhile. It might be good to poll blink-dev and see which of the diff formats are most useful. Ideally we'd be able to produce some sort of output that resembled what Rietveld and/or PolyGerrit will produce for diffs.
Mergedinto: 672651
Status: Duplicate (was: Unconfirmed)
Summary: Remove or replace PrettyPatch.rb. (was: Remove or replace PrettyPatch.rb?)

Sign in to add a comment