New issue
Advanced search Search tips

Issue 658311 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Layout Test virtual/threaded/fast/compositorworker/basic-plumbing-main-to-worker.html is flaky

Project Member Reported by joh...@chromium.org, Oct 21 2016

Issue description

The following layout test is flaky on [Win, Mac, Linux]

virtual/threaded/fast/compositorworker/basic-plumbing-main-to-worker.html

See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fthreaded%2Ffast%2Fcompositorworker%2Fbasic-plumbing-main-to-worker.html

It has the following text output when it fails:

This is a testharness.js-based test.
FAIL Tests that a change from the main thread is received on the compositor thread assert_equals: expected 0.5 but got 1
Harness: the test ran to completion.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef820db1411ad1ff23ae97c0a3bd2eb7184cc5e3

commit ef820db1411ad1ff23ae97c0a3bd2eb7184cc5e3
Author: johnme <johnme@chromium.org>
Date: Fri Oct 21 18:09:39 2016

Mark v/t/fast/compositorworker/basic-plumbing-main-to-worker.html flaky

BUG= 658311 
TBR=majidvp@chromium.org
NOTRY=true
NOTREECHECKS=true

Review-Url: https://chromiumcodereview.appspot.com/2441063002
Cr-Commit-Position: refs/heads/master@{#426842}

[modify] https://crrev.com/ef820db1411ad1ff23ae97c0a3bd2eb7184cc5e3/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by falken@chromium.org, Oct 24 2016

Components: Internals>Compositing>Animation
Components: -Blink>Workers
Removing Blink>Workers because this seems to be an issue of Compositor API (not an issue of the worker infrastructure).
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62535f1781f16f8995522924fa1e1218d3cbad39

commit 62535f1781f16f8995522924fa1e1218d3cbad39
Author: majidvp <majidvp@chromium.org>
Date: Tue Nov 15 21:10:54 2016

Fix flakiness in v/t/fast/compositorworker/basic-plumbing-main-to-worker.html

Most of the flakiness I have seen is related to the fact the waiting on one rAF
does not guarantee that the change is activated on the compositor. This is
fixed by waiting two rAF which ensures at least one activation has happened.

I have also noticed a rare crash which I am continuing to investigate.
This is why I am keeping the flakiness entry still.

BUG= 658311 

Review-Url: https://codereview.chromium.org/2499353002
Cr-Commit-Position: refs/heads/master@{#432257}

[modify] https://crrev.com/62535f1781f16f8995522924fa1e1218d3cbad39/third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/basic-plumbing-main-to-worker.html

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdc595432d97064286db8e2bdda3d8eb2119dbfc

commit fdc595432d97064286db8e2bdda3d8eb2119dbfc
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Dec 07 19:49:24 2016

Update TestExpectations by running Tools/Scripts/update-test-expectations.

This script removes lines for tests that appear to no longer flakily fail or timeout on the applicable platforms, according to recent results on the flakiness dashboard.

BUG=248938,446385, 513143 ,518987,522647, 532643 , 564403 , 569901 , 581468 , 605525 , 658311 , 658414 ,660308, 667953 , 671618 

Review-Url: https://codereview.chromium.org/2557593006
Cr-Commit-Position: refs/heads/master@{#437038}

[modify] https://crrev.com/fdc595432d97064286db8e2bdda3d8eb2119dbfc/third_party/WebKit/LayoutTests/TestExpectations

Is there any update to the investigation of flakiness mentioned in the CL description?
Labels: -Pri-1 Pri-3
Well, according to #6 the test is no longer flaky. I knew that we have addressed the main source of flakiness in #5 which is also confirmed by #6.

I have not worked on finding the rare crash cause but this issue should no longer be P1. Reducing the priority.
Components: -Blink>LayoutTests
Status: WontFix (was: Started)
No longer relevant as we removed CompositorWorker and related tests.

Sign in to add a comment