Shelf icons and background appear under keyboard overlay if shelf is auto-hidden |
||||||
Issue description1. Set shelf to auto-hide 2. Hit Ctrl-Alt-/ to show keyboard overlay. Note that it appears flush to the bottom of the screen. 3. Mouse down to reveal the shelf The status area widget and any shelf tooltips appear on top of the keyboard overlay. The shelf icons and gray background appear under the keyboard overlay. See screenshot. Seen in 55.0.2883.17 dev. Exists at least back to M53 stable. I don't think this is related to mustash refactoring -- it's possible it's always been this way. I'll bet it's due to the container hierarchy for the keyboard overlay. It could probably move up in the stack, but I'm not sure if that would break other things. Anyone know who owns virtual keyboard these days?
,
Oct 26 2016
+afakhry for the keyboard overlay
,
Oct 26 2016
tdanderson@ is correct. VK != keyboard overlay. Wow, that's ugly. :-( I'm thinking the correct thing to do is either to have the shelf be on top or to shift the keyboard overlay. Does it make sense to just have the keyboard overlay always positioned so that it doesn't interfere with the shelf? I don't see any reason why it MUST be firm against the bottom of the desktop.
,
Oct 27 2016
The keyboard overlay is currently positioned to the bottom of the work area, which is, in the case of a hidden shelf, the bottom of the screen. Albert suggestion sounds good to me. We can (1) inset the working area by the shelf height in all situations (regardless of the shelf visibility), (2) or do this only when the shelf is hidden. With (2) the shelf position will be consistent in all cases (my preferred solution) [attached screenshot with fix applied].
,
Oct 27 2016
This seems fine. Alternately, center it? The most of the shortcut keys don't actually work when you show the overlay, so there's not a lot of point to showing the underlying UI. (And a piece of polish for another day - it would be nice if the overlay window had rounded corners.)
,
Oct 27 2016
+jennschen for centering the keyboard overlay suggestion.
,
Oct 28 2016
Centering it SGTM.
,
Oct 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75c698249ed690540336ef9ee71cefa44e77f4e6 commit 75c698249ed690540336ef9ee71cefa44e77f4e6 Author: afakhry <afakhry@chromium.org> Date: Mon Oct 31 16:20:36 2016 Center Keyboard Overlay in the work area This is to avoid overlapping with the shelf when it's set to auto hide. BUG= 658307 TEST=Keyboard overlay should be in the center of the screen. TEST=ash_content_unittests --gtest_filter=ShelfAlignmentAny* Review-Url: https://codereview.chromium.org/2461053002 Cr-Commit-Position: refs/heads/master@{#428730} [modify] https://crrev.com/75c698249ed690540336ef9ee71cefa44e77f4e6/ash/content/keyboard_overlay/keyboard_overlay_delegate.cc [modify] https://crrev.com/75c698249ed690540336ef9ee71cefa44e77f4e6/ash/content/keyboard_overlay/keyboard_overlay_delegate_unittest.cc
,
Oct 31 2016
,
Nov 4 2016
Verified on ChromeOS 8959.0.0, 56.0.2908.0 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tdander...@chromium.org
, Oct 25 2016