New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 658303 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Update autofill profile address rewriter rules

Project Member Reported by rogerm@chromium.org, Oct 21 2016

Issue description

Update the address rewriter rules from the latest Geo grammars.

It's been a while since the last rule extraction and update.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bad57e09d4f88da3b7a296b90980d464a942b87

commit 4bad57e09d4f88da3b7a296b90980d464a942b87
Author: rogerm <rogerm@chromium.org>
Date: Fri Oct 21 19:24:13 2016

[autofill] Update autofill address rewriter rules.

Most if the changes are due to sort order of the rules, which has now been more fully specified. The rules used to be in order of decreasing length, with unspecified order for rules of the same length. Rules are now sorted on order of decreasing length and then in lexicographical order.

BUG=620414,  658303 

Review-Url: https://chromiumcodereview.appspot.com/2434003003
Cr-Commit-Position: refs/heads/master@{#426861}

[modify] https://crrev.com/4bad57e09d4f88da3b7a296b90980d464a942b87/components/autofill/core/browser/address_rewriter_rules.cc

Comment 2 by rogerm@chromium.org, Oct 25 2016

Labels: Merge-Request-55

Comment 3 by dimu@chromium.org, Oct 25 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 25 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10e5abd6805b97aabaf3e5102d22b45538920e0f

commit 10e5abd6805b97aabaf3e5102d22b45538920e0f
Author: Mathieu Perreault <mathp@chromium.org>
Date: Tue Oct 25 19:06:44 2016

[Merge M55][autofill] Update autofill address rewriter rules.

Most if the changes are due to sort order of the rules, which has now been more fully specified. The rules used to be in order of decreasing length, with unspecified order for rules of the same length. Rules are now sorted on order of decreasing length and then in lexicographical order.

BUG=620414,  658303 

Review-Url: https://chromiumcodereview.appspot.com/2434003003
Cr-Commit-Position: refs/heads/master@{#426861}
(cherry picked from commit 4bad57e09d4f88da3b7a296b90980d464a942b87)

Review URL: https://codereview.chromium.org/2450583003 .

Cr-Commit-Position: refs/branch-heads/2883@{#290}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/10e5abd6805b97aabaf3e5102d22b45538920e0f/components/autofill/core/browser/address_rewriter_rules.cc

Comment 5 by ma...@chromium.org, Oct 26 2016

Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10e5abd6805b97aabaf3e5102d22b45538920e0f

commit 10e5abd6805b97aabaf3e5102d22b45538920e0f
Author: Mathieu Perreault <mathp@chromium.org>
Date: Tue Oct 25 19:06:44 2016

[Merge M55][autofill] Update autofill address rewriter rules.

Most if the changes are due to sort order of the rules, which has now been more fully specified. The rules used to be in order of decreasing length, with unspecified order for rules of the same length. Rules are now sorted on order of decreasing length and then in lexicographical order.

BUG=620414,  658303 

Review-Url: https://chromiumcodereview.appspot.com/2434003003
Cr-Commit-Position: refs/heads/master@{#426861}
(cherry picked from commit 4bad57e09d4f88da3b7a296b90980d464a942b87)

Review URL: https://codereview.chromium.org/2450583003 .

Cr-Commit-Position: refs/branch-heads/2883@{#290}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/10e5abd6805b97aabaf3e5102d22b45538920e0f/components/autofill/core/browser/address_rewriter_rules.cc

Comment 7 by dimu@google.com, Nov 4 2016

[Automated comment] removing mislabelled merge-merged-2840

Comment 8 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment