New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 658295 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Making BrowserActivationWaiter a test support

Project Member Reported by warx@chromium.org, Oct 21 2016

Issue description

For BrowserActivationObserver class in popup_blocker_browsertest.cc, this can be a test support for browser interactive uitest.



 

Comment 1 by warx@chromium.org, Oct 21 2016

Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91ff5a8662a658007afd53608db8f965bb2b03d7

commit 91ff5a8662a658007afd53608db8f965bb2b03d7
Author: warx <warx@chromium.org>
Date: Fri Oct 21 20:35:12 2016

Refactor BrowserActivationWaiter as test support and move PopupBlockerBrowserTest to interactive_uitest

(1) Making BrowserActivationWaiter a common test support
(2) move PopupBlockerBrowserTest to interactive_uitest as there exists one test that is relying on native widget activation.

BUG= 658295 
TEST=utilizing the test support in PopupBlockerBrowserTest

Review-Url: https://chromiumcodereview.appspot.com/2441543004
Cr-Commit-Position: refs/heads/master@{#426878}

[modify] https://crrev.com/91ff5a8662a658007afd53608db8f965bb2b03d7/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc
[modify] https://crrev.com/91ff5a8662a658007afd53608db8f965bb2b03d7/chrome/test/BUILD.gn
[modify] https://crrev.com/91ff5a8662a658007afd53608db8f965bb2b03d7/chrome/test/base/ui_test_utils.cc
[modify] https://crrev.com/91ff5a8662a658007afd53608db8f965bb2b03d7/chrome/test/base/ui_test_utils.h

Comment 3 by warx@chromium.org, Oct 25 2016

Status: Fixed (was: Assigned)

Sign in to add a comment