New issue
Advanced search Search tips

Issue 658282 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.9% regression in media.tough_video_cases_extra at 426023:426075

Project Member Reported by liber...@chromium.org, Oct 21 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=658282

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgnay4uQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg7dGpsgoM


Bot(s) for this bug's original alert(s):

chromium-rel-win7-gpu-intel
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Oct 21 2016

Cc: s...@chromium.org
Owner: s...@chromium.org

=== Auto-CCing suspected CL author skym@chromium.org ===

Hi skym@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Fixing bad cleanup of multi part flag #endifs.
Author  : skym
Commit description:
  
BUG=

Review-Url: https://codereview.chromium.org/2432453002
Cr-Commit-Position: refs/heads/master@{#426036}
Commit  : 7248671d1809b1ba654f478490ced3e9cfa52945
Date    : Tue Oct 18 20:45:33 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@426022  910.42   1.31873  5  good
chromium@426029  911.869  1.16898  5  good
chromium@426033  910.183  1.70697  5  good
chromium@426035  911.618  1.17967  5  good
chromium@426036  921.955  6.76438  5  bad    <--
chromium@426049  918.718  5.74479  5  bad
chromium@426075  915.348  2.81395  8  bad

Bisect job ran on: winx64intel_perf_bisect
Bug ID: 658282

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests media.tough_video_cases_extra
Test Metric: seek/video.html?src_garden2_10s.mp4
Relative Change: 0.45%
Score: 98.0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64intel_perf_bisect/builds/1213
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8998177478305391312


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5827494098239488

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 4 by s...@chromium.org, Oct 21 2016

I'm skeptical my change affected this. All I did was change comments, and combine two #if define(OS_CHROMEOS) blocks. I don't see how it could have had a perf impact.
Cc: -liber...@chromium.org
Labels: OS-Windows
Owner: liber...@chromium.org
indeed.  i'll re-run bisect.
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Oct 24 2016

Bisect failed: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64intel_perf_bisect/builds/1214
Failure reason: the build has failed.
Additional errors:
The metric was not found in the test output.
Either of the initial "good" or "bad" revisions failed to be tested or built.

Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Oct 24 2016

Bisect failed: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64intel_perf_bisect/builds/1215
Failure reason: the build has failed.
Additional errors:
The metric was not found in the test output.
Either of the initial "good" or "bad" revisions failed to be tested or built.

Project Member

Comment 11 by 42576172...@developer.gserviceaccount.com, Oct 25 2016

Bisect failed: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64intel_perf_bisect/builds/1217
Failure reason: the build has failed.
Additional errors:
The metric was not found in the test output.
Either of the initial "good" or "bad" revisions failed to be tested or built.

Labels: Performance
Project Member

Comment 14 by 42576172...@developer.gserviceaccount.com, Apr 11 2017


=== BISECT JOB RESULTS ===
NO Perf regression found, tests failed to produce values

Bisect Details
  Configuration: winx64intel_perf_bisect
  Benchmark    : media.tough_video_cases_extra
  Metric       : seek/video.html?src_garden2_10s.mp4


To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter='video\.html\?src.garden2.10s\.mp4' media.tough_video_cases_extra

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8982632231270743744

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5268987422703616


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: Assigned (was: Untriaged)
Since there is an owner, this bug is not untriaged. Updating the status.
Status: WontFix (was: Assigned)
graph is now ~half what it was, lower is better.

Sign in to add a comment