New issue
Advanced search Search tips

Issue 658281 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 654323
Owner: ----
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

<settings-dropdown-menu> popups are ugly

Project Member Reported by derat@chromium.org, Oct 21 2016

Issue description

The popup / dropdown menus displayed for <settings-dropdown-menu> at chrome://md-settings are pretty ugly. Per stevenjb@, these have been hard to improve, but hopefully we can at least add some padding around the text in the menu.

I'm also attaching a screenshot of Polymer's <paper-dropdown-menu>'s popup, although I don't know how close to that we can get. It looks like <paper-dropdown-menu-light> is used in an add-printer dialog, and I'm also planning to use it for  issue 633455 , so we might have some inconsistency.
 
settings-dropdown-menu.png
31.0 KB View Download
paper-dropdown-menu.png
18.3 KB View Download

Comment 1 by derat@chromium.org, Oct 21 2016

Owner: ----
A bit of searching reveals that this is a limitation in Chrome that I'd encountered before but forgotten about: <option> can't be styled apart from foreground and background colors. :-(

It sounds like a common workaround is to use <ul> and <li> instead, although maybe the best approach here would be to make <settings-dropdown-menu> use <paper-menu> or <paper-listbox> instead of <select> and <option> (is there a reason why that wasn't done?). That's probably a fair bit beyond my current Polymer knowledge, though. :-)

Comment 2 by dpa...@chromium.org, Oct 21 2016

We migrated from paper-drodpown-menu to native <select> for various reasons, see https://bugs.chromium.org/p/chromium/issues/detail?id=651513. I don't think going back is an option, there has been a lot of discussion about it. I'll cc you on related conversations.

Comment 3 by derat@chromium.org, Oct 21 2016

Thanks for the context! I'll stick to the same <select>/<option> approach used by <settings-dropdown-menu>.

Comment 4 by dpa...@chromium.org, Oct 21 2016

So, can we close this bug? There does not seem to be any action item here. FWIW, we are still considering some minor UI tweaks to the existing <select>, see https://bugs.chromium.org/p/chromium/issues/detail?id=654323 for more details.

Comment 5 by dpa...@chromium.org, Oct 21 2016

Also the fact that you still see <paper-dropdown-menu> instances in some CrOS code, is because https://bugs.chromium.org/p/chromium/issues/detail?id=653689 has not been fully addressed yet.

Comment 6 by derat@chromium.org, Oct 21 2016

Mergedinto: 654323
Status: Duplicate (was: Untriaged)
Yes, it sounds like  issue 654323  (add additional horizontal padding by styling <select>) is the most that can be done as long as we're using <select>.

Sign in to add a comment