New issue
Advanced search Search tips

Issue 658279 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Expandable sections under "Language and input" aren't fully clickable

Project Member Reported by derat@chromium.org, Oct 21 2016

Issue description

At chrome://md-settings, the expandable sections under "Languages and input" (Language, Input method, Spell check) are less clickable than they ought to be: I can click on the down-arrow at the right to expand them, but the text or empty area isn't clickable. The whole bar should be clickable instead.
 
Screenshot 2016-10-21 at 09.55.23.png
33.8 KB View Download

Comment 1 by derat@chromium.org, Oct 21 2016

Cc: tbuck...@chromium.org
Cc: michae...@chromium.org
+michaelpg@

Comment 3 by dpa...@chromium.org, Nov 17 2016

Labels: Proj-MaterialDesign-WebUI
Cc: tommycli@chromium.org
Labels: Hotlist-MD-Settings-General
Owner: bettes@chromium.org
Status: Assigned (was: Untriaged)
For these expand/collapse rows, we should make clicking anywhere on the row expand it.

@Alan, what should the behavior be for rows with both an expand/collapse arrow and a toggle? One proposal:
1) If toggle is off, expand/collapse arrow should be hidden; clicking row should change the toggle
2) If toggle is on, clicking the row should expand/collapse it

Comment 5 by bettes@chromium.org, Nov 28 2016

Owner: tbuck...@chromium.org
As we've discussed in the past, removing inline editing is the ideal end goal:
https://docs.google.com/presentation/d/1U2cSeEkNB-m8pivfC7Od-ARMw7FW9KkoEIyWVfojqqw/edit#slide=id.g16c3343090_0_68

In the meantime, I think having Languages operate under the logic described in #4 is good. (This is how Network operates today)
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10719a79d0d6cf3cee559771cb5cca8f78024b5d

commit 10719a79d0d6cf3cee559771cb5cca8f78024b5d
Author: michaelpg <michaelpg@chromium.org>
Date: Wed Dec 07 09:05:21 2016

Language settings: fix focus issues

* Allow traversal through iron-list elements with up/down arrow keys.
  For input methods, <Enter> selects that input method.
* Tapping anywhere on a togglable row toggles that row.
* Make the buttons to open a subpage keyboard-focusable by wrapping their
  content in <a is="action-link">.
* Don't focus the Add Language dialog's Cancel button on opening.
* Other minor UI fixes.

BUG= 664106 , 668307 , 658279 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2523403003
Cr-Commit-Position: refs/heads/master@{#436894}

[modify] https://crrev.com/10719a79d0d6cf3cee559771cb5cca8f78024b5d/chrome/browser/resources/settings/languages_page/add_languages_dialog.html
[modify] https://crrev.com/10719a79d0d6cf3cee559771cb5cca8f78024b5d/chrome/browser/resources/settings/languages_page/add_languages_dialog.js
[modify] https://crrev.com/10719a79d0d6cf3cee559771cb5cca8f78024b5d/chrome/browser/resources/settings/languages_page/compiled_resources2.gyp
[modify] https://crrev.com/10719a79d0d6cf3cee559771cb5cca8f78024b5d/chrome/browser/resources/settings/languages_page/edit_dictionary_page.html
[modify] https://crrev.com/10719a79d0d6cf3cee559771cb5cca8f78024b5d/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/10719a79d0d6cf3cee559771cb5cca8f78024b5d/chrome/browser/resources/settings/languages_page/languages_page.js
[modify] https://crrev.com/10719a79d0d6cf3cee559771cb5cca8f78024b5d/ui/webui/resources/cr_elements/compiled_resources2.gyp
[add] https://crrev.com/10719a79d0d6cf3cee559771cb5cca8f78024b5d/ui/webui/resources/cr_elements/cr_expand_button/compiled_resources2.gyp

Owner: michae...@chromium.org
Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified on ChromeOS 9083.0.0, 57.0.2950.0

Sign in to add a comment