New issue
Advanced search Search tips

Issue 658263 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DualControlLayoutTest#testAlignSideBySide failing on JB devices

Reported by kra...@amazon.com, Oct 21 2016

Issue description

Version: Tip of master
OS: Android

What steps will reproduce the problem?
(1) Run DualControlLayoutTest#testAlignSideBySide on a JellyBean device
(NOTE: Not Jelly Bean MR 1+. This only repros on SDK level 16)

What is the expected output?
The test passes

What do you see instead?
C   26.225s Main  ********************************************************************************
C   26.225s Main  [FAIL] org.chromium.chrome.browser.widget.DualControlLayoutTest#testAlignSideBySide:
C   26.225s Main  junit.framework.AssertionFailedError: Primary should be on the right. expected:<3200> but was:<800>
C   26.225s Main  	at org.chromium.chrome.browser.widget.DualControlLayoutTest.runLayoutTest(DualControlLayoutTest.java:120)
C   26.225s Main  	at org.chromium.chrome.browser.widget.DualControlLayoutTest.testAlignSideBySide(DualControlLayoutTest.java:56)
C   26.225s Main  	at java.lang.reflect.Method.invokeNative(Native Method)
C   26.225s Main  	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
C   26.226s Main  	at android.test.InstrumentationTestCase.access$000(InstrumentationTestCase.java:36)
C   26.226s Main  	at android.test.InstrumentationTestCase$2.run(InstrumentationTestCase.java:189)
C   26.226s Main  	at android.app.Instrumentation$SyncRunnable.run(Instrumentation.java:1569)
C   26.226s Main  	at android.os.Handler.handleCallback(Handler.java:605)
C   26.226s Main  	at android.os.Handler.dispatchMessage(Handler.java:92)
C   26.226s Main  	at android.os.Looper.loop(Looper.java:137)
C   26.226s Main  	at android.app.ActivityThread.main(ActivityThread.java:4558)
C   26.226s Main  	at java.lang.reflect.Method.invokeNative(Native Method)
C   26.226s Main  	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:784)
C   26.226s Main  	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:551)
C   26.226s Main  	at dalvik.system.NativeStart.main(Native Method)
C   26.226s Main  ********************************************************************************
C   26.226s Main  Summary
C   26.226s Main  ********************************************************************************
C   26.227s Main  [==========] 1 test ran.
C   26.227s Main  [  PASSED  ] 0 tests.
C   26.227s Main  [  FAILED  ] 1 test, listed below:
C   26.227s Main  [  FAILED  ] org.chromium.chrome.browser.widget.DualControlLayoutTest#testAlignSideBySide
C   26.227s Main
C   26.227s Main  1 FAILED TEST
C   26.227s Main  ********************************************************************************

Please use labels and text to provide additional information.
Every method in that test class is already marked as TargetApi JellyBean MR 1.
This test is probably not expected to pass and shouldn't be run in the first place.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c441eed3a5dd0b720a993038179f01b119d3aee0

commit c441eed3a5dd0b720a993038179f01b119d3aee0
Author: kraush <kraush@amazon.com>
Date: Mon Nov 07 19:00:46 2016

Do not run DualControlLayoutTest#testAlignSideBySide on JB

Every method in DualControlLayoutTest is already tagged with TargetAPI
JellyBean MR1. This change disabled one of the tests accordingly to not
run on any devices prior to JellyBean MR 1.
The other DualControlLayoutTest works fine.

BUG= 658263 

Review-Url: https://codereview.chromium.org/2439083002
Cr-Commit-Position: refs/heads/master@{#430334}

[modify] https://crrev.com/c441eed3a5dd0b720a993038179f01b119d3aee0/chrome/android/javatests/src/org/chromium/chrome/browser/widget/DualControlLayoutTest.java

Status: Fixed (was: Untriaged)

Sign in to add a comment