We have LGTM from UI Review on theimproved duplicative downloads infobar outlined in Tal's proposal here: https://docs.google.com/document/d/1NbRsOtuMOT1AJwMyQcagI0Bi50vrKvfglspUSpUc1JM/edit Mocks and additional information found here: https://docs.google.com/presentation/d/1dFz09wgzykFM-_-XZh9PKDbTLAz_HDKVgPBMGCEASZA/edit#slide=id.g1781ef71a3_0_167 Please request additional specs if needed.
Min, does this fall into your bucket?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/577d7c791ae9a560d457bb08a8a959bd89eeec30 commit 577d7c791ae9a560d457bb08a8a959bd89eeec30 Author: qinmin <qinmin@chromium.org> Date: Thu Nov 10 23:07:42 2016 implementation for new duplicate download UI This change implements the new duplicate download UI. It renames the DownloadOverwriteInfobarXXXX to DuplicateDownloadInfobarXXXX. Chrome no longer show the overwrite button, and always creating a new file if user click on the download button. BUG= 658239 Review-Url: https://codereview.chromium.org/2478583004 Cr-Commit-Position: refs/heads/master@{#431389} [modify] https://crrev.com/577d7c791ae9a560d457bb08a8a959bd89eeec30/chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java [delete] https://crrev.com/a0c89995ac1b48c6886c0b339329bfdd42c27e7d/chrome/android/java/src/org/chromium/chrome/browser/infobar/DownloadOverwriteInfoBar.java [add] https://crrev.com/577d7c791ae9a560d457bb08a8a959bd89eeec30/chrome/android/java/src/org/chromium/chrome/browser/infobar/DuplicateDownloadInfoBar.java [modify] https://crrev.com/577d7c791ae9a560d457bb08a8a959bd89eeec30/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java [modify] https://crrev.com/577d7c791ae9a560d457bb08a8a959bd89eeec30/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/577d7c791ae9a560d457bb08a8a959bd89eeec30/chrome/android/java_sources.gni [modify] https://crrev.com/577d7c791ae9a560d457bb08a8a959bd89eeec30/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java [modify] https://crrev.com/577d7c791ae9a560d457bb08a8a959bd89eeec30/chrome/browser/BUILD.gn [add] https://crrev.com/577d7c791ae9a560d457bb08a8a959bd89eeec30/chrome/browser/android/download/android_download_manager_duplicate_infobar_delegate.cc [add] https://crrev.com/577d7c791ae9a560d457bb08a8a959bd89eeec30/chrome/browser/android/download/android_download_manager_duplicate_infobar_delegate.h [delete] https://crrev.com/a0c89995ac1b48c6886c0b339329bfdd42c27e7d/chrome/browser/android/download/android_download_manager_overwrite_infobar_delegate.cc [delete] https://crrev.com/a0c89995ac1b48c6886c0b339329bfdd42c27e7d/chrome/browser/android/download/android_download_manager_overwrite_infobar_delegate.h [modify] https://crrev.com/577d7c791ae9a560d457bb08a8a959bd89eeec30/chrome/browser/android/download/chrome_download_delegate.cc [delete] https://crrev.com/a0c89995ac1b48c6886c0b339329bfdd42c27e7d/chrome/browser/android/download/chrome_download_manager_overwrite_infobar_delegate.cc [delete] https://crrev.com/a0c89995ac1b48c6886c0b339329bfdd42c27e7d/chrome/browser/android/download/chrome_download_manager_overwrite_infobar_delegate.h [add] https://crrev.com/577d7c791ae9a560d457bb08a8a959bd89eeec30/chrome/browser/android/download/chrome_duplicate_download_infobar_delegate.cc [add] https://crrev.com/577d7c791ae9a560d457bb08a8a959bd89eeec30/chrome/browser/android/download/chrome_duplicate_download_infobar_delegate.h [delete] https://crrev.com/a0c89995ac1b48c6886c0b339329bfdd42c27e7d/chrome/browser/android/download/download_overwrite_infobar_delegate.cc [delete] https://crrev.com/a0c89995ac1b48c6886c0b339329bfdd42c27e7d/chrome/browser/android/download/download_overwrite_infobar_delegate.h [add] https://crrev.com/577d7c791ae9a560d457bb08a8a959bd89eeec30/chrome/browser/android/download/duplicate_download_infobar_delegate.cc [add] https://crrev.com/577d7c791ae9a560d457bb08a8a959bd89eeec30/chrome/browser/android/download/duplicate_download_infobar_delegate.h [modify] https://crrev.com/577d7c791ae9a560d457bb08a8a959bd89eeec30/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc [modify] https://crrev.com/577d7c791ae9a560d457bb08a8a959bd89eeec30/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h [modify] https://crrev.com/577d7c791ae9a560d457bb08a8a959bd89eeec30/chrome/browser/android/offline_pages/downloads/offline_page_infobar_delegate.cc [modify] https://crrev.com/577d7c791ae9a560d457bb08a8a959bd89eeec30/chrome/browser/android/offline_pages/downloads/offline_page_infobar_delegate.h [modify] https://crrev.com/577d7c791ae9a560d457bb08a8a959bd89eeec30/chrome/browser/download/chrome_download_manager_delegate.cc [modify] https://crrev.com/577d7c791ae9a560d457bb08a8a959bd89eeec30/chrome/browser/ui/BUILD.gn [delete] https://crrev.com/a0c89995ac1b48c6886c0b339329bfdd42c27e7d/chrome/browser/ui/android/infobars/download_overwrite_infobar.cc [delete] https://crrev.com/a0c89995ac1b48c6886c0b339329bfdd42c27e7d/chrome/browser/ui/android/infobars/download_overwrite_infobar.h [add] https://crrev.com/577d7c791ae9a560d457bb08a8a959bd89eeec30/chrome/browser/ui/android/infobars/duplicate_download_infobar.cc [add] https://crrev.com/577d7c791ae9a560d457bb08a8a959bd89eeec30/chrome/browser/ui/android/infobars/duplicate_download_infobar.h [modify] https://crrev.com/577d7c791ae9a560d457bb08a8a959bd89eeec30/chrome/browser/ui/android/infobars/infobar_android.h [modify] https://crrev.com/577d7c791ae9a560d457bb08a8a959bd89eeec30/components/infobars/core/infobar_delegate.h
Issue 651501 has been merged into this issue.
Comment 1 by dfalcant...@chromium.org
, Oct 24 2016Owner: qin...@chromium.org