New issue
Advanced search Search tips

Issue 658218 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Dec 2016
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Don't assume python is in /usr/bin in js_minify.py

Reported by wo...@opera.com, Oct 21 2016 
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.143 Safari/537.36

Steps to reproduce the problem:
1. put python 2 somewhere else than /usr/bin
2. build

What is the expected behavior?
closure compiler used to minify resources

What went wrong?
compiler errors

Did this work before? N/A 

Chrome version: 53.0.2785.143  Channel: n/a
OS Version: 
Flash Version: 

i use arch linux, where python 3 is default. when building projects that requrie python 2 i put python 2 before /usr/bin in my path. this works when shebang uses env to resolve python, but not when assuming /usr/bin/python is python 2.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f98d771de02d93a8bf4b01e8800516469677b90f

commit f98d771de02d93a8bf4b01e8800516469677b90f
Author: wonko <wonko@opera.com>
Date: Tue Oct 25 09:42:54 2016

Don't assume python is in /usr/bin in js_minify.py

BUG= 658218 

Review-Url: https://codereview.chromium.org/2438293002
Cr-Commit-Position: refs/heads/master@{#427304}

[modify] https://crrev.com/f98d771de02d93a8bf4b01e8800516469677b90f/third_party/closure_compiler/js_minify.py

Comment 2 by kavvaru@chromium.org, Dec 29 2016

Labels: TE-NeedsTriageHelp

Comment 3 by thomasanderson@chromium.org, Dec 30 2016

Status: Fixed (was: Unconfirmed)
so I guess this is fixed with #1?  Plmk if it's not and I'll reopen
►

Sign in to add a comment