New issue
Advanced search Search tips

Issue 658211 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

fast/text/line-break-ascii.html is slow on Win7 (dbg)

Project Member Reported by joh...@chromium.org, Oct 21 2016

Issue description

Looking at the flakiness dashboard:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Ftext%2Fline-break-ascii.html&testType=webkit_tests

About three quarters of runs of fast/text/line-break-ascii.html flakily timeout (TIMEOUT, TIMEOUT PASS, TIMEOUT TIMEOUT PASS, or similar statuses) on WebKit Win7 (dbg).

kojii: since you added this test, it probably makes sense for you to own this.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5aa42f6b27ef0c48e9db265907481f96a15fc5c

commit a5aa42f6b27ef0c48e9db265907481f96a15fc5c
Author: johnme <johnme@chromium.org>
Date: Fri Oct 21 12:51:38 2016

Mark fast/text/line-break-ascii.html as Slow

BUG= 658211 
NOTRY=true
NOTREECHECKS=true
TBR=kojii@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2437363002
Cr-Commit-Position: refs/heads/master@{#426778}

[modify] https://crrev.com/a5aa42f6b27ef0c48e9db265907481f96a15fc5c/third_party/WebKit/LayoutTests/SlowTests

Status: Available (was: Untriaged)
Components: -Blink>LayoutTests
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2162c6289d0bbafdfeae2aa8d9e9f7ac3e250b94

commit 2162c6289d0bbafdfeae2aa8d9e9f7ac3e250b94
Author: Koji Ishii <kojii@chromium.org>
Date: Wed Oct 25 04:04:52 2017

Make word-break-all-ascii.html faster

The fast/css3-text/css3-word-break/word-break-all-ascii.html is
slow because it forces layout to test one break opportunity,
and tests 8,836 break opportunities.

This patch changes it to create all test elements first, making
the forced layout down to once.

TBR=eae@chromium.org

Bug:  658211 
Change-Id: I732ba4340037a3bf99b2b979b064e1e86c5437fb
Reviewed-on: https://chromium-review.googlesource.com/734882
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511361}
[modify] https://crrev.com/2162c6289d0bbafdfeae2aa8d9e9f7ac3e250b94/third_party/WebKit/LayoutTests/fast/css3-text/css3-word-break/word-break-all-ascii-expected.txt
[modify] https://crrev.com/2162c6289d0bbafdfeae2aa8d9e9f7ac3e250b94/third_party/WebKit/LayoutTests/fast/css3-text/css3-word-break/word-break-all-ascii.html

Comment 5 by kojii@chromium.org, Oct 25 2017

Status: Fixed (was: Available)

Sign in to add a comment