New issue
Advanced search Search tips

Issue 658208 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Feb 2018
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

GN's bootstrap.py fails if python is in a non-standard PREFIX

Reported by codyo...@gmail.com, Oct 21 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.59 Safari/537.36

Steps to reproduce the problem:
if `env` is located anywhere other than `/usr/bin/env` GN's bootstrap.py will fail.

What is the expected behavior?

What went wrong?
tools/gn/bootstrap/bootstrap.py fails because it call build/write_buildflag_header.py which uses a shebang `#!/usr/bin/env python`, however not all Unix-like operating systems use the `/usr` PREFIX.

Did this work before? No 

Chrome version: 54.0.2840.59  Channel: dev
OS Version: n/a
Flash Version: Shockwave Flash 23.0 r0

There is already a fix for windows only that if the command is not null and ends in .py it prepends sys.executable.  It should be safe to remove the is_win check and simply always prepend it to python scripts called by bootstrap.py.

https://chromium.googlesource.com/chromium/src/tools/gn/+/b26616d48e3801ac0539080850ee9c6a2a916b9f/bootstrap/bootstrap.py#41
 
Labels: TE-NeedsTriageHelp
This issue seems to be out of TE-scope. Hence, marking TE-NeedsTriageHelp for further investigation.

Thanks...!!
Project Member

Comment 2 by sheriffbot@chromium.org, Feb 13 2018

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment