Issue 658144 link

Starred by 11 users

Issue metadata

Status:	Fixed
Owner:	----
Closed:	Jul 2017
Cc:	domenic@chromium.org
Components:	Blink>Network>StreamsAPI
EstimatedDays:	----
NextAction:	----
OS:	Linux , Android , Windows , Chrome , Mac
Pri:	2
Type:	Launch-OWP
Launch-Accessibility:	NA
Launch-Exp-Leadership:	----
Launch-Leadership:	----
Launch-Legal:	NA
Launch-M-Approved:	----
Launch-M-Target:	59-Stable
Launch-Privacy:	NA
Launch-Security:	NotReviewed
Launch-Test:	NA
Launch-UI:	NA
Rollout-Type:	----
OWP-Type-NewAPI OWP-Design-No OWP-Standards-UnofficialSpec Launch-Status-Review-Requested M-59

WritableStream (part of the Streams API)

Project Member Reported by ricea@chromium.org, Oct 21 2016

Issue description

Change description:
An API for writing to an arbitrary stream, with backpressure and queueing support.

Changes to API surface:
 * WritableStream interface

Links:
Streams Specification: https://streams.spec.whatwg.org/#ws

Support in other browsers:
Internet Explorer: No (?)
Firefox: No (Yes)
Safari: No (Yes)

Comment 1 by ricea@chromium.org, Nov 8 2016

Labels: -M-56 M-57

We're not going to make the feature freeze for M56, although it should be available behind a flag. Changed the label to M57.

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4162a4a2c1e2e897b65e769d5f8e6d3fcd0e0da7

commit 4162a4a2c1e2e897b65e769d5f8e6d3fcd0e0da7
Author: ricea <ricea@chromium.org>
Date: Wed Nov 09 06:49:16 2016

Implementation of WritableStream

Implement WritableStream as specified in the Streams standard:

https://streams.spec.whatwg.org/#ws

The implementation is in Javascript using V8 Extras, similar to
ReadableStream.js. Currently WritableStream is behind a flag.

The implementation follows ReadableStream.js closely, except that internal slots
are prefixed with an underscore instead of the name of the class, to make
comparison with the standard text easier.

Layout tests have been imported from reference-implementation/to-upstream-wpts/writable-streams/ in the Stream Standard repository:
https://github.com/whatwg/streams/tree/master/reference-implementation/to-upstream-wpts/writable-streams
They will be upstreamed to the w3c web-platform-tests and used from there in future.

test-initializer.js is from w3c/web-platform-tests.

BUG= 658144 

Review-Url: https://codereview.chromium.org/2453713003
Cr-Commit-Position: refs/heads/master@{#430881}

[modify] https://crrev.com/4162a4a2c1e2e897b65e769d5f8e6d3fcd0e0da7/build_overrides/v8.gni
[modify] https://crrev.com/4162a4a2c1e2e897b65e769d5f8e6d3fcd0e0da7/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[add] https://crrev.com/4162a4a2c1e2e897b65e769d5f8e6d3fcd0e0da7/third_party/WebKit/LayoutTests/http/tests/streams/resources/recording-streams.js
[add] https://crrev.com/4162a4a2c1e2e897b65e769d5f8e6d3fcd0e0da7/third_party/WebKit/LayoutTests/http/tests/streams/resources/test-initializer.js
[add] https://crrev.com/4162a4a2c1e2e897b65e769d5f8e6d3fcd0e0da7/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/aborting.https.html
[add] https://crrev.com/4162a4a2c1e2e897b65e769d5f8e6d3fcd0e0da7/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/aborting.js
[add] https://crrev.com/4162a4a2c1e2e897b65e769d5f8e6d3fcd0e0da7/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/bad-underlying-sinks.https.html
[add] https://crrev.com/4162a4a2c1e2e897b65e769d5f8e6d3fcd0e0da7/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/bad-underlying-sinks.js
[add] https://crrev.com/4162a4a2c1e2e897b65e769d5f8e6d3fcd0e0da7/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/close.https.html
[add] https://crrev.com/4162a4a2c1e2e897b65e769d5f8e6d3fcd0e0da7/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/close.js
[add] https://crrev.com/4162a4a2c1e2e897b65e769d5f8e6d3fcd0e0da7/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/constructor.https.html
[add] https://crrev.com/4162a4a2c1e2e897b65e769d5f8e6d3fcd0e0da7/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/constructor.js
[add] https://crrev.com/4162a4a2c1e2e897b65e769d5f8e6d3fcd0e0da7/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/general.https.html
[add] https://crrev.com/4162a4a2c1e2e897b65e769d5f8e6d3fcd0e0da7/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/general.js
[add] https://crrev.com/4162a4a2c1e2e897b65e769d5f8e6d3fcd0e0da7/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/start.https.html
[add] https://crrev.com/4162a4a2c1e2e897b65e769d5f8e6d3fcd0e0da7/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/start.js
[add] https://crrev.com/4162a4a2c1e2e897b65e769d5f8e6d3fcd0e0da7/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/write.https.html
[add] https://crrev.com/4162a4a2c1e2e897b65e769d5f8e6d3fcd0e0da7/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/write.js
[modify] https://crrev.com/4162a4a2c1e2e897b65e769d5f8e6d3fcd0e0da7/third_party/WebKit/LayoutTests/http/tests/worklet/webexposed/global-interface-listing-paint-worklet-expected.txt
[modify] https://crrev.com/4162a4a2c1e2e897b65e769d5f8e6d3fcd0e0da7/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/4162a4a2c1e2e897b65e769d5f8e6d3fcd0e0da7/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-compositor-worker-expected.txt
[modify] https://crrev.com/4162a4a2c1e2e897b65e769d5f8e6d3fcd0e0da7/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/4162a4a2c1e2e897b65e769d5f8e6d3fcd0e0da7/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/4162a4a2c1e2e897b65e769d5f8e6d3fcd0e0da7/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[add] https://crrev.com/4162a4a2c1e2e897b65e769d5f8e6d3fcd0e0da7/third_party/WebKit/Source/core/streams/WritableStream.js

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aff3d02ed430c9039ec2cc8b4f36f28687e2d6ce

commit aff3d02ed430c9039ec2cc8b4f36f28687e2d6ce
Author: ricea <ricea@chromium.org>
Date: Tue Nov 15 06:25:17 2016

WritableStream: minor bug fixes

* Constructing a WritableStream with a highWaterMark of NaN resulting in
  a TypeError. It should have been a RangeError. Fixed.
* Constructing a WritableStreamDefaultController should fail if the
  WritableStream already had a controller. It did not. Fixed.

BUG= 658144 

Review-Url: https://codereview.chromium.org/2499943002
Cr-Commit-Position: refs/heads/master@{#432131}

[modify] https://crrev.com/aff3d02ed430c9039ec2cc8b4f36f28687e2d6ce/third_party/WebKit/Source/core/streams/WritableStream.js

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f612d40629cf7619bd0b3435758f12dd0d68f26d

commit f612d40629cf7619bd0b3435758f12dd0d68f26d
Author: ricea <ricea@chromium.org>
Date: Wed Nov 16 06:43:06 2016

Import latest WritableStream tests from upstream

This imports the latest tests from
https://github.com/whatwg/streams/tree/master/reference-implementation/to-upstream-wpts/writable-streams
as of commit a3c394a8131e6ef7f86f80521f1f3fd2790b6071 (Nov 11 2016).

The updated tests provide a considerable improvement in test coverage.

Minor modifications have been made for compatibility with the layout test
environment.

These tests are in this location temporarily until they have been
upstreamed to the w3c web-platform-tests repository.

BUG= 658144 

Review-Url: https://codereview.chromium.org/2500833002
Cr-Commit-Position: refs/heads/master@{#432406}

[modify] https://crrev.com/f612d40629cf7619bd0b3435758f12dd0d68f26d/third_party/WebKit/LayoutTests/http/tests/streams/resources/test-utils.js
[modify] https://crrev.com/f612d40629cf7619bd0b3435758f12dd0d68f26d/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/aborting.js
[add] https://crrev.com/f612d40629cf7619bd0b3435758f12dd0d68f26d/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/bad-strategies.https.html
[add] https://crrev.com/f612d40629cf7619bd0b3435758f12dd0d68f26d/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/bad-strategies.js
[modify] https://crrev.com/f612d40629cf7619bd0b3435758f12dd0d68f26d/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/bad-underlying-sinks.js
[add] https://crrev.com/f612d40629cf7619bd0b3435758f12dd0d68f26d/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/brand-checks.https.html
[add] https://crrev.com/f612d40629cf7619bd0b3435758f12dd0d68f26d/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/brand-checks.js
[add] https://crrev.com/f612d40629cf7619bd0b3435758f12dd0d68f26d/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/byte-length-queuing-strategy.https.html
[add] https://crrev.com/f612d40629cf7619bd0b3435758f12dd0d68f26d/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/byte-length-queuing-strategy.js
[modify] https://crrev.com/f612d40629cf7619bd0b3435758f12dd0d68f26d/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/close.js
[add] https://crrev.com/f612d40629cf7619bd0b3435758f12dd0d68f26d/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/count-queuing-strategy.https.html
[add] https://crrev.com/f612d40629cf7619bd0b3435758f12dd0d68f26d/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/count-queuing-strategy.js
[modify] https://crrev.com/f612d40629cf7619bd0b3435758f12dd0d68f26d/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/general.js
[modify] https://crrev.com/f612d40629cf7619bd0b3435758f12dd0d68f26d/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/start.js
[modify] https://crrev.com/f612d40629cf7619bd0b3435758f12dd0d68f26d/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/write.js

Comment 5 by ricea@chromium.org, Jan 11 2017

Labels: -M-57 M-58

We missed the feature freeze for M57. Bumping to M58.

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78dd11ea48a9967a31b7064cbdcea8eb61ca73dc

commit 78dd11ea48a9967a31b7064cbdcea8eb61ca73dc
Author: ricea <ricea@chromium.org>
Date: Thu Jan 12 10:45:08 2017

Fix crash in WritableStreamFinishClose

WritableStreamFinishClose would fail if the writer had been
detached. Add checks to stop this happening.

This updates the implementation to match Streams Standard version

https://github.com/whatwg/streams/commit/347667724b8a4b83fcc379b730603cf4cd0d6e91

which is current as of 12 Jan 2017.

Also update the tests to the same commit.

BUG= 658144 

Review-Url: https://codereview.chromium.org/2625873008
Cr-Commit-Position: refs/heads/master@{#443201}

[modify] https://crrev.com/78dd11ea48a9967a31b7064cbdcea8eb61ca73dc/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/close.js
[modify] https://crrev.com/78dd11ea48a9967a31b7064cbdcea8eb61ca73dc/third_party/WebKit/Source/core/streams/WritableStream.js

Comment 7 by ricea@chromium.org, Mar 7 2017

Labels: -M-58 M-59

Missed the feature freeze for M58. Bumping to M59.

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a6e635d6929c77e10c45ae069b15003b3f1cf73a

commit a6e635d6929c77e10c45ae069b15003b3f1cf73a
Author: domenic <domenic@chromium.org>
Date: Fri Mar 31 05:58:15 2017

Add V8 extra utils for promise state

This will allow V8 extra consumers to track promise state without
using a side-table. This is used by streams as of
https://github.com/whatwg/streams/commit/173f9f67be56f6690f82ec26fe86c8e67256616b.

BUG= chromium:658144 

Review-Url: https://codereview.chromium.org/2784213002
Cr-Commit-Position: refs/heads/master@{#44287}

[modify] https://crrev.com/a6e635d6929c77e10c45ae069b15003b3f1cf73a/src/js/prologue.js
[modify] https://crrev.com/a6e635d6929c77e10c45ae069b15003b3f1cf73a/test/cctest/test-api.cc
[modify] https://crrev.com/a6e635d6929c77e10c45ae069b15003b3f1cf73a/test/cctest/test-extra.js

Comment 9 by ricea@chromium.org, Apr 3 2017

Blink "Intent to Ship" thread:

https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/qpY1dj_ND-Q

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6dbcaaae9b0de50e03a7b11cb0506a8b4b42923f

commit 6dbcaaae9b0de50e03a7b11cb0506a8b4b42923f
Author: ricea <ricea@chromium.org>
Date: Tue Apr 04 06:24:11 2017

Ship WritableStream

TBR=brettw@chromium.org
R=tyoshino@chromium.org
BUG= 658144 

Review-Url: https://codereview.chromium.org/2790623004
Cr-Commit-Position: refs/heads/master@{#461643}

[modify] https://crrev.com/6dbcaaae9b0de50e03a7b11cb0506a8b4b42923f/.gn
[modify] https://crrev.com/6dbcaaae9b0de50e03a7b11cb0506a8b4b42923f/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/6dbcaaae9b0de50e03a7b11cb0506a8b4b42923f/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/6dbcaaae9b0de50e03a7b11cb0506a8b4b42923f/third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/6dbcaaae9b0de50e03a7b11cb0506a8b4b42923f/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/6dbcaaae9b0de50e03a7b11cb0506a8b4b42923f/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt

Comment 11 by ricea@chromium.org, Apr 4 2017

Labels: -Launch-Privacy-NotReviewed -Launch-Legal-NotReviewed -Launch-Test-NotReviewed -Launch-Accessibility-NotReviewed Launch-Accessibility-NA Launch-Legal-NA Launch-Privacy-NA Launch-Status-Review-Requested Launch-Test-NA

Comment 12 by ricea@chromium.org, Apr 4 2017

Labels: -Launch-UI-NotReviewed Launch-UI-NA

Project Member

Comment 13 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3105d5e2ffe590989bbbda65e5b0e66a4a5049bd

commit 3105d5e2ffe590989bbbda65e5b0e66a4a5049bd
Author: ricea <ricea@chromium.org>
Date: Wed Apr 12 08:00:31 2017

Update WritableStream to new standard version

This CL updates the WritableStream implementation from standard version
347667724b8a4b83fcc379b730603cf4cd0d6e91 to
https://github.com/whatwg/streams/commit/830c24e023d24b353afe755aba47e5c67ad5cf5c

Most significant changes (all come from the standard):
* WritableStream abort logic clean up
* Sink abort() will no longer be called while sink start() is executing
* desiredSize calculation is now clamped to match the standard
* Protection against re-entrant strategy size() functions
* Many bug fixes

Implementation notes:
* WritableStream now has a [[backpressure]] flag.
  This is packed into the same field as the [[state]] field, which is
  now called _stateAndFlags.
* WritableStreamDefaultController now only has one flag, [[started]],
  so _defaultControllerFlags is gone and [[started]] has a field to
  itself.
* It does not appear to be possible to dispatch to a method named by a
  V8 PrivateSymbol via the prototype chain, so static dispatch is used
  for [[AbortSteps]], [[ErrorSteps]] and [[StartSteps]] instead.
* A new V8 internal method v8.promiseState() is used to check the
  [[PromiseStatus]] field mentioned in the standard.

All streams/writable-streams web-platform-tests now pass; as a result
expectations are removed.

The obsolete copy of the web-platform-tests in
http/tests/streams/writable-streams is also gone.

The changed semantics of abort() necessitated a minor change in the
implementation of ReadableStream.pipeTo(). Apart from this change, ReadableStream has *not* been updated to the latest spec version.

BUG= 658144 ,626703

Review-Url: https://codereview.chromium.org/2772293002
Cr-Commit-Position: refs/heads/master@{#463954}

[modify] https://crrev.com/3105d5e2ffe590989bbbda65e5b0e66a4a5049bd/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/aborting-expected.txt
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/aborting.dedicatedworker-expected.txt
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/aborting.serviceworker.https-expected.txt
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/aborting.sharedworker-expected.txt
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/floating-point-total-queue-size-expected.txt
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/floating-point-total-queue-size.serviceworker.https-expected.txt
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/general-expected.txt
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/general.dedicatedworker-expected.txt
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/general.serviceworker.https-expected.txt
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/general.sharedworker-expected.txt
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/start-expected.txt
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/start.dedicatedworker-expected.txt
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/start.serviceworker.https-expected.txt
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/start.sharedworker-expected.txt
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/write-expected.txt
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/write.dedicatedworker-expected.txt
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/write.serviceworker.https-expected.txt
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/write.sharedworker-expected.txt
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/aborting.https-expected.txt
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/aborting.https.html
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/aborting.js
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/bad-strategies.https-expected.txt
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/bad-strategies.https.html
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/bad-strategies.js
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/bad-underlying-sinks.https-expected.txt
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/bad-underlying-sinks.https.html
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/bad-underlying-sinks.js
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/brand-checks.https-expected.txt
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/brand-checks.https.html
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/brand-checks.js
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/byte-length-queuing-strategy.https-expected.txt
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/byte-length-queuing-strategy.https.html
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/byte-length-queuing-strategy.js
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/close.https-expected.txt
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/close.https.html
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/close.js
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/constructor.https-expected.txt
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/constructor.https.html
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/constructor.js
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/count-queuing-strategy.https-expected.txt
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/count-queuing-strategy.https.html
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/count-queuing-strategy.js
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/general.https-expected.txt
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/general.https.html
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/general.js
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/start.https-expected.txt
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/start.https.html
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/start.js
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/write.https-expected.txt
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/write.https.html
[delete] https://crrev.com/db77d9c68e2df6c5d5c626455a19d9a1aef76598/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/write.js
[modify] https://crrev.com/3105d5e2ffe590989bbbda65e5b0e66a4a5049bd/third_party/WebKit/Source/core/streams/ReadableStream.js
[modify] https://crrev.com/3105d5e2ffe590989bbbda65e5b0e66a4a5049bd/third_party/WebKit/Source/core/streams/WritableStream.js

Comment 14 by ricea@chromium.org, May 9 2017

Labels: Launch-M-Target-59-Stable

Comment 15 by ricea@chromium.org, Jun 12 2017

Owner: ----
Status: Available (was: Assigned)

This shipped in M59. Okay to close the issue?

Comment 16 by ricea@chromium.org, Jul 26 2017

Status: Fixed (was: Available)

►

Issue 658144 link

Issue metadata

WritableStream (part of the Streams API)

Issue description

Comment 1 by ricea@chromium.org, Nov 8 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Nov 9 2016

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Nov 15 2016

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Nov 16 2016

Comment 4 Deleted

Comment 5 by ricea@chromium.org, Jan 11 2017

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Jan 12 2017

Comment 6 Deleted

Comment 7 by ricea@chromium.org, Mar 7 2017

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Mar 31 2017

Comment 8 Deleted

Comment 9 by ricea@chromium.org, Apr 3 2017

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Apr 4 2017

Comment 10 Deleted

Comment 11 by ricea@chromium.org, Apr 4 2017

Comment 11 Deleted

Comment 12 by ricea@chromium.org, Apr 4 2017

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Apr 12 2017

Comment 13 Deleted

Comment 14 by ricea@chromium.org, May 9 2017

Comment 14 Deleted

Comment 15 by ricea@chromium.org, Jun 12 2017

Comment 15 Deleted

Comment 16 by ricea@chromium.org, Jul 26 2017

Comment 16 Deleted

Sign in to add a comment