New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 658124 link

Starred by 2 users
Status: Fixed
Owner:
█ warx@chromium.org
Last visit > 30 days ago
Closed: Oct 2016
Cc:
sky@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Consider creating a ViewsTestBase subclass for interactive uitest

Project Member Reported by warx@chromium.org, Oct 21 2016 
For example, WidgetTestInteractive subclasses from WidgetTest (which subclasses from ViewTestBase)

There are some common works for the setup.
      gl::GLSurfaceTestSupport::InitializeOneOff();
      ui::RegisterPathProvider();
      base::FilePath ui_test_pak_path;
      ASSERT_TRUE(PathService::Get(ui::UI_TEST_PAK, &ui_test_pak_path));
      ui::ResourceBundle::InitSharedInstanceWithPakPath(ui_test_pak_path);

If we can extract the common setup work to a new subclass, which can save the duplicate code lines and make writing interactive_ui_tests better.

See also,
src/ui/views/widget/desktop_aura/x11_topmost_window_finder_interactive_uitest.cc
src/ui/views/widget/desktop_aura/desktop_window_tree_host_x11_interactive_uitest.cc
src/ui/views/corewm/desktop_capture_controller_unittest.cc
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/713c5ab48ce2a75a99927f1da48c1ff0477eda84

commit 713c5ab48ce2a75a99927f1da48c1ff0477eda84
Author: warx <warx@chromium.org>
Date: Tue Oct 25 00:39:41 2016

Create and apply ViewsInteractiveUITestBase

BUG= 658124 
TEST=self sustained

Review-Url: https://codereview.chromium.org/2442933002
Cr-Commit-Position: refs/heads/master@{#427191}

[modify] https://crrev.com/713c5ab48ce2a75a99927f1da48c1ff0477eda84/ui/views/BUILD.gn
[modify] https://crrev.com/713c5ab48ce2a75a99927f1da48c1ff0477eda84/ui/views/corewm/DEPS
[modify] https://crrev.com/713c5ab48ce2a75a99927f1da48c1ff0477eda84/ui/views/corewm/desktop_capture_controller_unittest.cc
[add] https://crrev.com/713c5ab48ce2a75a99927f1da48c1ff0477eda84/ui/views/test/views_interactive_ui_test_base.cc
[add] https://crrev.com/713c5ab48ce2a75a99927f1da48c1ff0477eda84/ui/views/test/views_interactive_ui_test_base.h
[modify] https://crrev.com/713c5ab48ce2a75a99927f1da48c1ff0477eda84/ui/views/widget/desktop_aura/desktop_window_tree_host_x11_interactive_uitest.cc
[modify] https://crrev.com/713c5ab48ce2a75a99927f1da48c1ff0477eda84/ui/views/widget/desktop_aura/x11_topmost_window_finder_interactive_uitest.cc
[modify] https://crrev.com/713c5ab48ce2a75a99927f1da48c1ff0477eda84/ui/views/widget/native_widget_aura_interactive_uitest.cc
[modify] https://crrev.com/713c5ab48ce2a75a99927f1da48c1ff0477eda84/ui/views/widget/widget_interactive_uitest.cc

Comment 2 by warx@chromium.org, Oct 25 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment