Consolidate MacViews+Harmony flags on Mac (there should be one flag, not three) |
||||||
Issue descriptionChrome 56.0.2893.0 OSX 10.11.6 What steps will reproduce the problem? (1) Enable MacViews, but not Harmony (2) Visit https://permission.site (3) Press on "Location" (4) Press and hold "Allow" in the permission bubble. What is the expected output? "Allow stays readable" What do you see instead? "Allow" stays white. (See screenshot. Please use labels and text to provide additional information.
,
Nov 7 2016
This is expected - we aren't shipping any MacViews UI without Harmony, and non-Harmony MacViews is only partly implemented. If you plan to ship non-Harmony MacViews UI, please consult with the MacViews team.
,
Nov 15 2016
> we aren't shipping any MacViews UI without Harmony In that case, could we simplify the flags and the code paths to assume that?
,
Nov 15 2016
Yup.
,
Nov 22 2016
Issue 667639 has been merged into this issue.
,
Nov 24 2016
,
Nov 24 2016
Thanks for the CL, tapted@ – I appreciate the flag simplification a lot!
,
Nov 29 2016
,
Dec 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25c139f15b7a4fc7d6f652ac48ba8688e1e9fbc9 commit 25c139f15b7a4fc7d6f652ac48ba8688e1e9fbc9 Author: tapted <tapted@chromium.org> Date: Thu Dec 01 07:39:03 2016 MacViews: Consolidate flags. Just use --secondary-ui-md to enable MacViews. The "Harmony" control style diverges sufficiently from AppKit controls such that we should no longer distinguish between "WebUI" and "AppKit" themes for native dialogs when selecting whether to use the toolkit-views or Cocoa version of a dialog. Also the toolkit-views theme currently breaks on Mac when not used in conjunction with --secondary-ui-md. --secondary-ui-md describes the outcome nicely, so collapse the "MacViewsNativeDialogs" and "MacViewsWebUIDialogs" feature flags into --secondary-ui-md. BUG= 658105 Review-Url: https://codereview.chromium.org/2524213002 Cr-Commit-Position: refs/heads/master@{#435575} [modify] https://crrev.com/25c139f15b7a4fc7d6f652ac48ba8688e1e9fbc9/chrome/app/generated_resources.grd [modify] https://crrev.com/25c139f15b7a4fc7d6f652ac48ba8688e1e9fbc9/chrome/browser/about_flags.cc [modify] https://crrev.com/25c139f15b7a4fc7d6f652ac48ba8688e1e9fbc9/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/25c139f15b7a4fc7d6f652ac48ba8688e1e9fbc9/chrome/browser/ui/browser_dialogs.h [delete] https://crrev.com/e9b2ece8b371f59f37e42159da4c00313d67407f/chrome/browser/ui/browser_dialogs_mac.cc [modify] https://crrev.com/25c139f15b7a4fc7d6f652ac48ba8688e1e9fbc9/chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_views.mm [modify] https://crrev.com/25c139f15b7a4fc7d6f652ac48ba8688e1e9fbc9/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller.mm [modify] https://crrev.com/25c139f15b7a4fc7d6f652ac48ba8688e1e9fbc9/chrome/browser/ui/cocoa/browser_window_controller.mm [modify] https://crrev.com/25c139f15b7a4fc7d6f652ac48ba8688e1e9fbc9/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.mm [modify] https://crrev.com/25c139f15b7a4fc7d6f652ac48ba8688e1e9fbc9/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm [modify] https://crrev.com/25c139f15b7a4fc7d6f652ac48ba8688e1e9fbc9/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm [modify] https://crrev.com/25c139f15b7a4fc7d6f652ac48ba8688e1e9fbc9/chrome/browser/ui/cocoa/login_handler_cocoa.mm [modify] https://crrev.com/25c139f15b7a4fc7d6f652ac48ba8688e1e9fbc9/chrome/browser/ui/cocoa/task_manager_mac.mm [modify] https://crrev.com/25c139f15b7a4fc7d6f652ac48ba8688e1e9fbc9/chrome/browser/ui/cocoa/website_settings/permission_prompt_impl_views_mac.mm [modify] https://crrev.com/25c139f15b7a4fc7d6f652ac48ba8688e1e9fbc9/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm [modify] https://crrev.com/25c139f15b7a4fc7d6f652ac48ba8688e1e9fbc9/chrome/browser/ui/javascript_dialogs/javascript_dialog_mac.cc [modify] https://crrev.com/25c139f15b7a4fc7d6f652ac48ba8688e1e9fbc9/chrome/browser/ui/views/browser_dialogs_views_mac.cc
,
Dec 1 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by lgar...@chromium.org
, Oct 21 2016