When links are really long, our word break makes for some weird layouts See screenshots for examples
Proposal: anchor links break on letters, expand-toggle-triangles are always next to the start of the text they are tied to.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ece209ef4fba37f1eb500fa61e128bac2c9a5e8f commit ece209ef4fba37f1eb500fa61e128bac2c9a5e8f Author: luoe <luoe@chromium.org> Date: Fri Nov 04 22:04:57 2016 DevTools: Fix wrapping bugs in console Links in console messages now break on all letters, avoiding weird layouts. The class "console-message-text" used to refer to both the message content body and the anchor, but now it just refers to the content body. For trace messages, the expansion arrow is now a pseudo element on the content body, which is still clickable. Certain network errors were logged in the format "GET" + " " + url + description. This led to weird wrapping of the word "GET". By combining the empty space after "GET" with the word itself, the word no longer splits by letter. BUG= 658096 Review-Url: https://codereview.chromium.org/2472183002 Cr-Commit-Position: refs/heads/master@{#430026} [modify] https://crrev.com/ece209ef4fba37f1eb500fa61e128bac2c9a5e8f/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js [modify] https://crrev.com/ece209ef4fba37f1eb500fa61e128bac2c9a5e8f/third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-links-expected.txt [modify] https://crrev.com/ece209ef4fba37f1eb500fa61e128bac2c9a5e8f/third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-stack-in-errors-expected.txt [modify] https://crrev.com/ece209ef4fba37f1eb500fa61e128bac2c9a5e8f/third_party/WebKit/LayoutTests/inspector/console/console-object-preview-expected.txt [modify] https://crrev.com/ece209ef4fba37f1eb500fa61e128bac2c9a5e8f/third_party/WebKit/LayoutTests/inspector/console/console-proxy-expected.txt [modify] https://crrev.com/ece209ef4fba37f1eb500fa61e128bac2c9a5e8f/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js [modify] https://crrev.com/ece209ef4fba37f1eb500fa61e128bac2c9a5e8f/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js [modify] https://crrev.com/ece209ef4fba37f1eb500fa61e128bac2c9a5e8f/third_party/WebKit/Source/devtools/front_end/console/consoleView.css
Comment 1 by l...@chromium.org
, Oct 25 2016345 KB
345 KB View Download