New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 658094 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Make "to allow pairing" not be a link in the WebBluetooth chooser

Project Member Reported by juncai@chromium.org, Oct 21 2016

Issue description

When Bluetooth is turned off, "Turn on Bluetooth to allow pairing" is shown in the chooser as a link text. It would be better to make "to allow pairing" not be a link.
 

Comment 1 by juncai@chromium.org, Oct 21 2016

Status: Started (was: Assigned)

Comment 2 by juncai@chromium.org, Oct 22 2016

Cc: rolfe@chromium.org
Here are some screenshots.
WebBluetooth_adapter_off_ChromeOS.png
60.3 KB View Download
WebBluetooth_adapter_off_Mac.png
107 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa577cb63de06844e1ea65db7aa4f228a050a423

commit aa577cb63de06844e1ea65db7aa4f228a050a423
Author: juncai <juncai@chromium.org>
Date: Mon Oct 24 19:27:33 2016

Make "to allow pairing" not be a link in the WebBluetooth chooser

When the Bluetooth adapter is off, the chooser will show:
"Turn on Bluetooth to allow pairing", the whole text is a link.
This CL modifies code to make only "Turn on Bluetooth" a link.
And the "to allow pairing" text is not a link.

I uploaded some screenshots in the issue page.

BUG= 658094 

Review-Url: https://codereview.chromium.org/2439453006
Cr-Commit-Position: refs/heads/master@{#427116}

[modify] https://crrev.com/aa577cb63de06844e1ea65db7aa4f228a050a423/chrome/app/generated_resources.grd
[modify] https://crrev.com/aa577cb63de06844e1ea65db7aa4f228a050a423/chrome/browser/ui/cocoa/chooser_content_view_cocoa.h
[modify] https://crrev.com/aa577cb63de06844e1ea65db7aa4f228a050a423/chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm
[modify] https://crrev.com/aa577cb63de06844e1ea65db7aa4f228a050a423/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm
[modify] https://crrev.com/aa577cb63de06844e1ea65db7aa4f228a050a423/chrome/browser/ui/views/chooser_content_view.cc
[modify] https://crrev.com/aa577cb63de06844e1ea65db7aa4f228a050a423/chrome/browser/ui/views/chooser_content_view.h
[modify] https://crrev.com/aa577cb63de06844e1ea65db7aa4f228a050a423/chrome/browser/ui/views/chooser_content_view_unittest.cc

Comment 4 by juncai@chromium.org, Oct 24 2016

Status: Fixed (was: Started)

Sign in to add a comment