New issue
Advanced search Search tips

Issue 658091 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Don't sort YV channels for CrCb formats.

Project Member Reported by dcasta...@chromium.org, Oct 21 2016

Issue description

EGL_EXT_image_dma_buf_import did not clearly specify the plane order in case of a multi planar format.

Different drivers interpreted the spec in different way. We initially tried to work around the different drivers.

Eventually Khronos clarified the spec and we changed the drivers.

https://codereview.chromium.org/2413853003 reverted the workaround.

Opening this bug to track the merge to 55.

More details in b/31469091
 
crrev.com/2432853007 us ready to land when the merge is approved.

Comment 2 by gov...@chromium.org, Oct 21 2016

Labels: OS-Chrome
Per b/31469091, this seems like a Chrome OS specific issue. 
Status: Fixed (was: Started)
Labels: -Merge-Request-55 Merge-Approved-55
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 22 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a022c26bbc3556164016d021d6ee6d3ceefa505

commit 4a022c26bbc3556164016d021d6ee6d3ceefa505
Author: dcastagna <dcastagna@chromium.org>
Date: Sat Oct 22 07:24:31 2016

ozone: Don't sort YV channels for CrCb formats.

After all, we decided to follow up with Khronos and it seems like
the EGL_EXT_image_dma_buf_import extension spec will be amended
so that if a CrCb format is passed, the second plane represents
Cr and the third one Cb when creating the image.
https://cvs.khronos.org/bugzilla/show_bug.cgi?id=16017

This CL reverts the logic introduced with crrev.com/2295943002

Mali drivers are being modified accordingly.

BUG= 658091 ,b/31469091
TEST=Ran on kevin with custom mali drivers, and on elm.
NOPRESUBMIT=true
NOTRY=true

Review-Url: https://chromiumcodereview.appspot.com/2413853003
Cr-Commit-Position: refs/heads/master@{#426180}
(cherry picked from commit a8593dfd625a66f5e05eec78dc5be01f5d606b45)

Review-Url: https://chromiumcodereview.appspot.com/2432853007
Cr-Commit-Position: refs/branch-heads/2883@{#237}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/4a022c26bbc3556164016d021d6ee6d3ceefa505/ui/ozone/gl/gl_image_ozone_native_pixmap.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a022c26bbc3556164016d021d6ee6d3ceefa505

commit 4a022c26bbc3556164016d021d6ee6d3ceefa505
Author: dcastagna <dcastagna@chromium.org>
Date: Sat Oct 22 07:24:31 2016

ozone: Don't sort YV channels for CrCb formats.

After all, we decided to follow up with Khronos and it seems like
the EGL_EXT_image_dma_buf_import extension spec will be amended
so that if a CrCb format is passed, the second plane represents
Cr and the third one Cb when creating the image.
https://cvs.khronos.org/bugzilla/show_bug.cgi?id=16017

This CL reverts the logic introduced with crrev.com/2295943002

Mali drivers are being modified accordingly.

BUG= 658091 ,b/31469091
TEST=Ran on kevin with custom mali drivers, and on elm.
NOPRESUBMIT=true
NOTRY=true

Review-Url: https://chromiumcodereview.appspot.com/2413853003
Cr-Commit-Position: refs/heads/master@{#426180}
(cherry picked from commit a8593dfd625a66f5e05eec78dc5be01f5d606b45)

Review-Url: https://chromiumcodereview.appspot.com/2432853007
Cr-Commit-Position: refs/branch-heads/2883@{#237}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/4a022c26bbc3556164016d021d6ee6d3ceefa505/ui/ozone/gl/gl_image_ozone_native_pixmap.cc

Comment 7 by dimu@google.com, Nov 4 2016

[Automated comment] removing mislabelled merge-merged-2840

Comment 8 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Comment 9 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 10 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 11 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 12 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 14 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment