New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 658090 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Test platform_CUPSDaemon seems to be in the wrong suite

Reported by jrbarnette@chromium.org, Oct 21 2016

Issue description

The test platform_CUPSDaemon is in the bvt-inline suite.
A cursory glance at the purpose of this test suggests that's
the wrong suite, and that bvt-cq would be preferable.

Here are the relevant criteria for a test in bvt-inline
(taken from test_suites/control.bvt-inline in the Autotest
sources):
 2. A test failure should indicate one or more of the following
    impacts is possible:
     * The failure may impact the stability of the test lab.
     * The failure may prevent discovery of other bugs.
     * The failure may block ordinary development tasks.

That is, bvt-inline is meant to find major test-stoppers.
The focus is on login and security tests.  Operationally,
a failure in bvt-inline is meant to trigger engagement
from the sheriffs.  Failures in this suite also block
all follow-on testing of other features; the build is
classified as DOA.

Here are the relevant criteria for a test in bvt-cq
(taken from test_suites/control.bvt-cq in the Autotest
sources):
 2. A test failure should indicate that the product is not fit for
    release on any channel.

The bvt-cq test is meant to find bugs in specific subsystems
that while critical, don't prevent using the system for most
testing or development purposes.  CLs must pass bvt-cq to be
accepted into the tree, but failures in the canary should
generally be treated as "file a bug against the failing subsystem."
 

Comment 1 by ka...@chromium.org, Sep 14 2017

Issue 765007 has been merged into this issue.
Cc: briannorris@chromium.org s...@chomium.org
Cc: ka...@chromium.org
Presumably kalin@ will be modifying this?

https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/666379
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c912f30aee89f7141cee7680228a6d6d837da93f

commit c912f30aee89f7141cee7680228a6d6d837da93f
Author: Kalin Stoyanov <kalin@chromium.org>
Date: Fri Sep 15 03:14:14 2017

Move platform_CUPSDaemon to bvt-cq

BUG= chromium:658090 
TEST=Test is running successfully now on the bvt-inline suite

Change-Id: Ifc3956e7832e705c2edbddc8c2f2cee054aec83d
Reviewed-on: https://chromium-review.googlesource.com/666379
Commit-Ready: Kalin Stoyanov <kalin@chromium.org>
Tested-by: Kalin Stoyanov <kalin@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>

[modify] https://crrev.com/c912f30aee89f7141cee7680228a6d6d837da93f/client/site_tests/platform_CUPSDaemon/control

Owner: ka...@chromium.org
Status: Fixed (was: Unconfirmed)
Labels: -Pri-3 Pri-1
Actually, not certain if this is the right bug (to me it's not really a bvt-cq vs bvt-inline question, both of the run in the CQ anyway) but P1 because flake in this test is impacting the CQ. I'm open to moving the flake chase to a separate bug though.

Comment 9 by cywang@chromium.org, Nov 10 2017

How about disabling this test until the race condition is fixed?

Comment 10 by ka...@chromium.org, Nov 10 2017

Yes, we can move the test back to bvt-perbuild.
I'll open a new bug.

Thia one should be resolved.

Comment 11 by ka...@chromium.org, Nov 10 2017

Status: Verified (was: Unconfirmed)

Sign in to add a comment