New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 658089 link

Starred by 2 users
Status: Fixed
Owner:
█ lushnikov@chromium.org
Last visit 29 days ago
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[REGRESSION] DevTools: editing of file system file blinks on page reload

Project Member Reported by lushnikov@chromium.org, Oct 21 2016 
What steps will reproduce the problem?
(1) Open DevTools
(2) Setup a workspace
(3) Open a Sources panel, navigate to a file which is mapped to network
(4) Reload page

What is the expected output?
Opened file stays intact

What do you see instead?
Opened file blinks.

Comment 1 by lushnikov@chromium.org, Oct 21 2016 

This is a conceptual problem, happened as a result of migration on the new "persistence" (see https://goo.gl/PVKxyv)

During migration, it was decided to always show user the network file, if any. So in case of mapped filesystem file, the user is actually operates a network file, which goes away on reload. 

This was a wrong decision. We should always show user a file-system-based file.

Meanwhile, a light-weight solution for the annoyance should be introduced and merged to M55.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d70e6764b38821da712088fe67bbed2c563922d8

commit d70e6764b38821da712088fe67bbed2c563922d8
Author: lushnikov <lushnikov@chromium.org>
Date: Tue Oct 25 03:47:51 2016

DevTools: restore selection and scrollposition between network and filesystem

BUG= 658089 
R=dgozman

Review-Url: https://codereview.chromium.org/2435043003
Cr-Commit-Position: refs/heads/master@{#427268}

[modify] https://crrev.com/d70e6764b38821da712088fe67bbed2c563922d8/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-merge-editor-tabs-expected.txt
[modify] https://crrev.com/d70e6764b38821da712088fe67bbed2c563922d8/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-merge-editor-tabs.html
[modify] https://crrev.com/d70e6764b38821da712088fe67bbed2c563922d8/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-search-across-all-files-expected.txt
[modify] https://crrev.com/d70e6764b38821da712088fe67bbed2c563922d8/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-test.js
[modify] https://crrev.com/d70e6764b38821da712088fe67bbed2c563922d8/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/resources/foo.js
[modify] https://crrev.com/d70e6764b38821da712088fe67bbed2c563922d8/third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
[modify] https://crrev.com/d70e6764b38821da712088fe67bbed2c563922d8/third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js
[modify] https://crrev.com/d70e6764b38821da712088fe67bbed2c563922d8/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js

Comment 3 by lushnikov@chromium.org, Oct 27 2016

Labels: -lusha-merge-tbd M-55 Merge-Request-55
Restoring of scrolling behavior works fine; it would be good to have it merged to M-55.

Comment 4 by lushnikov@chromium.org, Oct 27 2016

Labels: lusha-merge-tbd

Comment 5 by dimu@chromium.org, Oct 27 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 28 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15959f46c0626d85c720976f4a3a7752e50cde0a

commit 15959f46c0626d85c720976f4a3a7752e50cde0a
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Fri Oct 28 22:37:40 2016

DevTools: restore selection and scrollposition between network and filesystem

BUG= 658089 
R=dgozman

Review-Url: https://codereview.chromium.org/2435043003
Cr-Commit-Position: refs/heads/master@{#427268}
(cherry picked from commit d70e6764b38821da712088fe67bbed2c563922d8)

Review URL: https://codereview.chromium.org/2456413003 .

Cr-Commit-Position: refs/branch-heads/2883@{#367}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/15959f46c0626d85c720976f4a3a7752e50cde0a/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-merge-editor-tabs-expected.txt
[modify] https://crrev.com/15959f46c0626d85c720976f4a3a7752e50cde0a/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-merge-editor-tabs.html
[modify] https://crrev.com/15959f46c0626d85c720976f4a3a7752e50cde0a/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-search-across-all-files-expected.txt
[modify] https://crrev.com/15959f46c0626d85c720976f4a3a7752e50cde0a/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-test.js
[modify] https://crrev.com/15959f46c0626d85c720976f4a3a7752e50cde0a/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/resources/foo.js
[modify] https://crrev.com/15959f46c0626d85c720976f4a3a7752e50cde0a/third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
[modify] https://crrev.com/15959f46c0626d85c720976f4a3a7752e50cde0a/third_party/WebKit/Source/devtools/front_end/source_frame/SourcesTextEditor.js
[modify] https://crrev.com/15959f46c0626d85c720976f4a3a7752e50cde0a/third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js

Comment 7 by lushnikov@chromium.org, Oct 28 2016

Status: Fixed (was: Assigned)
This reduces scroll jumping and preserves selection; in order to eliminate blinking altogether, we should switch to showing filesystem file instead of network file, but this is out of scope of this particular issue.
►

Sign in to add a comment