git cl upload hangs after presubmit checks |
||||
Issue descriptiongit cl upload hangs after presubmit checks pass. Sample output: Using 50% similarity for rename/copy detection. Override with --similarity. Running presubmit upload checks ... Presubmit checks took 1.6s to calculate. Presubmit checks passed. >>>>> All this runs in a couple seconds, and then hangs <various files> This branch is associated with issue <number>. Adding patch to that issue. Upload server: https://codereview.chromium.org (change with -s/--server) Title describing this patch set [<commit message>]: <message> Issue updated. URL: https://codereview.chromium.org/<number> (patchset: 20001) <files> <<<<<<<<<<<<<<<< This all eventually comes up, and is pretty speedy once it does. The long wait time is in between this and the <various files> being displayed. It eventually always works, but it can take between a few seconds and several minutes to complete.
,
Nov 22 2016
Basically two things happen between the end of the presubmit checks, and printing those files. 1) If you're uploading to Rietveld, it hits the network to determine the latest patchset on rietveld, it hits the filesystem to determine the latest patchset number you've uploaded locally, and warns you if Rietveld is ahead of your local machine (i.e. you uploaded from a different machine and then didn't sync). That network call could be flakily slow. 2) It tries to print those file stats. This basically means running a 'git diff --stat'. If the change is large, or is sitting on a slow filesystem, this could be very slow. I honestly don't think there's a lot I can do here. (1) will be resolved with the transition to Gerrit. (2) could be resolved with a git-cl flag, or you could move your checkout onto an SSD if it isn't already. We haven't received other complaints about this. Do you know of anyone else who experiences similar hangs? Are there commonalities between their machines, or the CLs you experience this on?
,
Nov 23 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 29 2017
cannot reproduce |
||||
►
Sign in to add a comment |
||||
Comment 1 by rdevlin....@chromium.org
, Oct 25 2016