Should we consider this for a respin?

Yes. Definitely. 
I don't see a problem with this one though: http://feedback/#/Report/14382165397

Can see this issue http://feedback/#/Report/14378785569, but it is seen only momentarily.  Not consistently reproducible.  Rate of reproducible 1/5

Steps:
1. Sign into chrome with account which has lot of bookmarks (ex: blingtest8/testBling!)
2. Go to Menu --> Bookmarks
3. And, wait for the bookmarks to sync.

For 2 to 3 seconds bookmark icons are not displayed.

Attached is the video 

https://drive.google.com/a/google.com/file/d/0Bz2uwV55gGwDZDY0bzU3Tm5uTzQ/view?usp=sharing

2 to 3 seconds for what I can see is hundreds of bookmarks is not too bad. Might just be poor performance. We can optimize this, but I don't think that slow-to-load favicons are urgent enough to include in respin. 

I am much more interested in how to reproduce the completely broken https://feedback.corp.google.com/product/282/neutron?lView=rd&lReport=20601612230 

Hi Robert,

We did see reports about this in 53 as well and in reviewing the sync logs of those reports found that many people had offline status (which would explain sync not being synced yet), so just wanted to double check what kind of spike/increase you are seeing in this kind of report since 54 was pushed live?

If there is a specific bucket you want me to review (if its not the same as last time's bookmarks bucket) please let me know.

Thanks,

Hi Lindsay,

Yes, it seems like the one in M53. 
Please kindly find the bucket below. 
I saw # of reports jump from 2-3 a day to 16 a day on 10/20.
Will users see this issue more when there is a Chrome update? 
https://hotsauce.corp.google.com/product/282/neutron?lView=td&lCategory=8590004707&lTagFamily=%23issue&lTagSearch=bookmarks&lTagId=a11:69647b14:930161&lRSort=1&lROrder=2&lRFilter=1&lReportSearch=tag:%23label%3Eblingm54

Thanks

Ok cool, I'll check through these and will post an update if I see any trends in the logs of the reports.

Issue is reproducible (http://feedback/#/Report/14378785569). Rate of reproducibility 5/5.

Issue is reproducible only on iOS 10 devices.

Issue is not reproducible on M53.0.2785.109

Steps to repro:
1. Have more than 20 bookmarks saved to repro this issue.
2. Go to Menu --> Scroll the bookmarks up and down.

Notice that the favicons disappear.

Video:
https://drive.google.com/a/google.com/file/d/0Bz2uwV55gGwDZkFUcTd5eTFIcUE/view?usp=sharing

This should be fixed and release in a refresh IMO. It's easily reproducible and without having hundreds of bookmarks. It's in M55 as well.

I'm surprised we didn't catch it earlier. 

I forked the seemingly unrelated user feedback http://feedback/#/Report/20601612230 into  crbug.com/658709 . Let's keep this issue limited to favicons disappearing on scroll (steps in Comment #8)

Thanks for repro steps, vbarigela. 

The issue is a result in UICollectionView behavior changes in iOS 10. Here is how we fetch bookmarks:

1. In collectionView:cellForItemAtIndexPath: we call cellForBookmark:indexPath:, that in turn calls loadFaviconAtIndexPath:. This, in turn, calls GetLargeIconOrFallbackStyle on LargeIconService, that is asynchronous.
2. In the callback, we check if the cell is currently displayed by calling [UICollectionView indexPathsForVisibleItems]. If the cell is visible, we set the image. If it's not, we don't.

The interesting thing is, the GetLargeIconOrFallbackStyle is async but is called (almost) immediately, with either the actual icon or fallback icon.
On iOS 9, when UICollectionView calls collectionView:cellForItemAtIndexPath:, [UICollectionView indexPathsForVisibleItems] contains this index path.
On iOS 10, the cell is requested *before* it is visible, so the icon is never set when you scroll. I'm not sure why this changed, and it seems to not be discussed on the internet. I'm also not sure why we didn't catch it earlier. But I'm sure we'll be able to fix this.
 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/1458470b30516761353a6df26502f454dc3b8562

commit 1458470b30516761353a6df26502f454dc3b8562
Author: stkhapugin <stkhapugin@google.com>
Date: Mon Oct 24 15:46:52 2016

Will check on canary tomorrow and request cherry-picks. 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/6381521e27b7bbe127f2f029d7942dac49ab2feb

commit 6381521e27b7bbe127f2f029d7942dac49ab2feb
Author: justincohen <justincohen@google.com>
Date: Mon Oct 24 18:02:59 2016

[Automated comment] Request affecting a post-stable build (M54), manual review required.

Your change meets the bar and is auto-approved for M55 (branch: 2883)

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/e3bfe9f027adccb31bca34e77830498d957eca41

commit e3bfe9f027adccb31bca34e77830498d957eca41
Author: stkhapugin <stkhapugin@google.com>
Date: Tue Oct 25 15:44:32 2016

Please update the status of this bug.

This issue is fixed on chrome canary version 56.0.2903.0.  Verified on iPad 4 and iPhone 6 plus with iOS 10.1.

Woohoo, canary is out and the issue doesn't repro. Cherry-picking now. 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/236b3a316b73c9a6a919e104942f109aa88d7b3d

commit 236b3a316b73c9a6a919e104942f109aa88d7b3d
Author: stkhapugin <stkhapugin@google.com>
Date: Tue Oct 25 15:44:32 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/6caf6e4425cdfc0a5b03c9aebfdd980b23b8b384

commit 6caf6e4425cdfc0a5b03c9aebfdd980b23b8b384
Author: stkhapugin <stkhapugin@google.com>
Date: Tue Oct 25 15:44:32 2016

Verified on chrome dev version 54.0.2840.91 on iPhone 6 with iOS 10.0.2, iPad Air with iOS 10.1.  Bookmark favicon's are displayed on scrolling the bookmarks.  Looks good.

Verified on chrome beta version 55.0.2883.33 on iPhone 6 with iOS 10.0.2, iPad Air with iOS 10.1.  Bookmark favicon's are displayed on scrolling the bookmarks.  Looks good.

PM at go/bling-favicons-pm