New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 658066 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Feb 2018
Cc:
domenic@chromium.org
█ dominicc@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 652579



Sign in to add a comment

imported/wpt/custom-elements/htmlconstructor/newtarget.html is failing

Project Member Reported by dominicc@chromium.org, Oct 20 2016 
ToT, eg r426630, fails these tests because they don't retrieve the constructor's prototype but instead cache it. There's also follow-on steps for invalid prototypes which look up a built-in constructor in a particular global.

Comment 1 by dominicc@chromium.org, Oct 20 2016 

Here's the relevant part of the spec:

https://html.spec.whatwg.org/#html-element-constructors
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a21493ce8e12e552cd51c85523d451357bd427e1

commit a21493ce8e12e552cd51c85523d451357bd427e1
Author: dominicc <dominicc@chromium.org>
Date: Tue Oct 25 09:44:59 2016

createElement should not transmit exceptions but report them.

BUG= 652157 , 658066 

Review-Url: https://codereview.chromium.org/2443543002
Cr-Commit-Position: refs/heads/master@{#427306}

[modify] https://crrev.com/a21493ce8e12e552cd51c85523d451357bd427e1/third_party/WebKit/LayoutTests/custom-elements/spec/construct.html
[modify] https://crrev.com/a21493ce8e12e552cd51c85523d451357bd427e1/third_party/WebKit/LayoutTests/custom-elements/spec/create-element-defined-synchronous.html
[modify] https://crrev.com/a21493ce8e12e552cd51c85523d451357bd427e1/third_party/WebKit/LayoutTests/custom-elements/spec/report-the-exception.html
[modify] https://crrev.com/a21493ce8e12e552cd51c85523d451357bd427e1/third_party/WebKit/LayoutTests/custom-elements/spec/resources/custom-elements-helpers.js
[delete] https://crrev.com/d3440cefcf916da441e0a3f417b6664ea5d0fd52/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/Document-createElement-expected.txt
[modify] https://crrev.com/a21493ce8e12e552cd51c85523d451357bd427e1/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp
[modify] https://crrev.com/a21493ce8e12e552cd51c85523d451357bd427e1/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h
[modify] https://crrev.com/a21493ce8e12e552cd51c85523d451357bd427e1/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/a21493ce8e12e552cd51c85523d451357bd427e1/third_party/WebKit/Source/core/dom/custom/CustomElement.cpp
[modify] https://crrev.com/a21493ce8e12e552cd51c85523d451357bd427e1/third_party/WebKit/Source/core/dom/custom/CustomElement.h
[modify] https://crrev.com/a21493ce8e12e552cd51c85523d451357bd427e1/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h
[modify] https://crrev.com/a21493ce8e12e552cd51c85523d451357bd427e1/third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.h
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e2ff264b2d6eaddcf5546b83bb382dd91ae833e

commit 8e2ff264b2d6eaddcf5546b83bb382dd91ae833e
Author: dominicc <dominicc@chromium.org>
Date: Tue Oct 25 13:23:26 2016

Retrieve prototype during custom element construction.

BUG= 649158 , 658066 

Review-Url: https://codereview.chromium.org/2441943002
Cr-Commit-Position: refs/heads/master@{#427333}

[modify] https://crrev.com/8e2ff264b2d6eaddcf5546b83bb382dd91ae833e/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/8e2ff264b2d6eaddcf5546b83bb382dd91ae833e/third_party/WebKit/LayoutTests/custom-elements/constructor-context-dies-cross-context-call.html
[add] https://crrev.com/8e2ff264b2d6eaddcf5546b83bb382dd91ae833e/third_party/WebKit/LayoutTests/custom-elements/constructor-context-dies-retrieving-prototype.html
[modify] https://crrev.com/8e2ff264b2d6eaddcf5546b83bb382dd91ae833e/third_party/WebKit/LayoutTests/imported/wpt/custom-elements/htmlconstructor/newtarget-expected.txt
[modify] https://crrev.com/8e2ff264b2d6eaddcf5546b83bb382dd91ae833e/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp
[modify] https://crrev.com/8e2ff264b2d6eaddcf5546b83bb382dd91ae833e/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h
[modify] https://crrev.com/8e2ff264b2d6eaddcf5546b83bb382dd91ae833e/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.cpp
[modify] https://crrev.com/8e2ff264b2d6eaddcf5546b83bb382dd91ae833e/third_party/WebKit/Source/bindings/core/v8/V8HTMLConstructor.cpp

Comment 5 by dominicc@chromium.org, Oct 26 2016

Blocking: 652579
Cc: dominicc@chromium.org
Owner: yurak@google.com
OK, the only remaining failing parts are to do with customized built-in elements.

Comment 6 by dominicc@chromium.org, Oct 31 2016 

I think the remaining failures there are because the upstream test is buggy--yurak noticed it asserts the prototype is HTMLParagraphElement (ie the interface object and not the interface prototype object.)
Project Member

Comment 7 by sheriffbot@chromium.org, Jan 20 2017

Labels: Hotlist-Recharge-BouncingOwner
Status: Untriaged (was: Started)
The assigned owner "yurak@google.com" is not able to receive e-mails, please re-triage.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by cda...@chromium.org, Jan 20 2017

Owner: ----

Comment 9 by dominicc@chromium.org, Jan 24 2017

Cc: -yurak@google.com -dominicc@chromium.org
Owner: dominicc@chromium.org
Status: Assigned (was: Untriaged)

Comment 10 by dominicc@chromium.org, Aug 22 2017

Cc: dominicc@chromium.org
Owner: ----
Status: Available (was: Assigned)
Bulk disowning per sshruthi's email about bug triage best practices.

Comment 11 by tkent@chromium.org, Feb 9 2018

Status: Fixed (was: Available)
I think issues described here were already fixed.
 Issue 808365  is responsible for the current failures for customized built-in elements.
►

Sign in to add a comment