New issue
Advanced search Search tips

Issue 658057 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Direct-leak in v8::internal::wasm::DecodeWasmModule

Project Member Reported by ClusterFuzz, Oct 20 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5174034759417856

Fuzzer: libfuzzer_radamsa_v8_wasm_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Direct-leak
Crash Address: 
Crash State:
  v8::internal::wasm::DecodeWasmModule
  v8::internal::wasm::testing::DecodeWasmModuleForTesting
  v8::internal::wasm::testing::CompileInstantiateWasmModuleForTesting
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=426478:426526

Minimized Testcase (0.01 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95R8MifhzDLzJBvY0s8JnfwiOBLrfL9wAF6K6tKvYF1f-uC8KMwvdzVSsYhiXXpiGvx9HlUtWVp9a9fLD6Q9V7eW6ZX6FfmWupyIgjLa6qcZy2BVumaM1EC7YpYxz47EaEqll9RByDWyX_OncFj3nkarvTOlQ?testcase_id=5174034759417856

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 

Comment 1 by ajha@chromium.org, Oct 21 2016

Cc: ajha@chromium.org
Components: Blink>JavaScript
Labels: Test-Findit-Correct M-56
Owner: titzer@chromium.org
Status: Assigned (was: Untriaged)
Suspected CLs	The result is a list of CLs that change the crashed files.

Author: titzer
Project: chromium-v8
Changelist: https://chromium.googlesource.com/v8/v8.git/+/418b239f0b379cbf97bc74b93a31d61382a1ed13
Time: Wed Oct 19 13:06:44 2016
Lines 34, 82-85, 91, 108 of file wasm-module-runner.cc which potentially caused crash are changed in this cl (frame #2, "v8::internal::wasm::testing::DecodeWasmModuleForTesting"; frame #3, "v8::internal::wasm::testing::CompileInstantiateWasmModuleForTesting"; frame #4, "v8::internal::wasm::testing::CompileAndRunWasmModule").

Lines 1091-1102 of file module-decoder.cc which potentially caused crash are changed in this cl (frame #1, "v8::internal::wasm::DecodeWasmModule"; frame #1, "v8::internal::wasm::DecodeWasmModule").
Minimum distance from crash line to modified line: 0. (file: wasm-module-runner.cc, crashed on: 34, modified: 34).

Suspected Project: chromium-v8

Based on the above Find It result assigning to titzer@ for further investigation.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/1fe7a91751ceb7fd037ad2539feb320797cda96e

commit 1fe7a91751ceb7fd037ad2539feb320797cda96e
Author: ahaas <ahaas@chromium.org>
Date: Wed Oct 26 12:08:32 2016

[wasm] Fix memory leak in wasm-module-runner.cc

BUG= chromium:658057 
R=titzer@chromium.org

Review-Url: https://codereview.chromium.org/2446593002
Cr-Commit-Position: refs/heads/master@{#40586}

[modify] https://crrev.com/1fe7a91751ceb7fd037ad2539feb320797cda96e/test/common/wasm/wasm-module-runner.cc

Labels: Test-Predator-Correct
Project Member

Comment 4 by ClusterFuzz, Oct 28 2016

ClusterFuzz has detected this issue as fixed in range 427848:428120.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5174034759417856

Fuzzer: libfuzzer_radamsa_v8_wasm_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Direct-leak
Crash Address: 
Crash State:
  v8::internal::wasm::DecodeWasmModule
  v8::internal::wasm::testing::DecodeWasmModuleForTesting
  v8::internal::wasm::testing::CompileInstantiateWasmModuleForTesting
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=426478:426526
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=427848:428120

Minimized Testcase (0.01 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95R8MifhzDLzJBvY0s8JnfwiOBLrfL9wAF6K6tKvYF1f-uC8KMwvdzVSsYhiXXpiGvx9HlUtWVp9a9fLD6Q9V7eW6ZX6FfmWupyIgjLa6qcZy2BVumaM1EC7YpYxz47EaEqll9RByDWyX_OncFj3nkarvTOlQ?testcase_id=5174034759417856

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Oct 28 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 6 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment