New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 658054 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

TracingBrowserTest.TestMemoryInfra is flaky

Project Member Reported by pkasting@chromium.org, Oct 20 2016

Issue description

Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_side_navigation_browser_tests&tests=TracingBrowserTest.TestMemoryInfra

Sample failing run: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/47902/steps/browser_side_navigation_browser_tests%20on%20Ubuntu-12.04/logs/stdio

Output:

[ RUN      ] TracingBrowserTest.TestMemoryInfra
../../chrome/test/base/tracing_browsertest.cc:80: Failure
Expected: (std::string::npos) != (json_events.find("process_totals")), actual: 18446744073709551615 vs 18446744073709551615
[  FAILED  ] TracingBrowserTest.TestMemoryInfra, where TypeParam =  and GetParam() =  (1383 ms)

The earliest failure I can find on the dashboard is associated with the range https://test-results.appspot.com/revision_range?start=426107&end=426116 .  Tentatively assigning to chiniforooshan, who landed a CL in that range mentioning "tracing" -- I don't necessarily think this is related, but maybe you can triage better than I can?
 
Status: Assigned (was: Untriaged)
This has started flaking a lot, 6 of 7 of the last runs failed. Started with https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/50036

Same error as above. I don't see any suspicious CLs at or right before that build.
Cc: ssid@chromium.org
Fwiw, I can't repro locally.

Disabling in https://codereview.chromium.org/2575033002/
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c48ca16ce1146ceb5083886cafcef307f46eb8a2

commit c48ca16ce1146ceb5083886cafcef307f46eb8a2
Author: grunell <grunell@chromium.org>
Date: Wed Dec 14 11:44:43 2016

Disabling flaky test TracingBrowserTest.TestMemoryInfra on Linux.

TBR=primiano@chromium.org

BUG= 658054 

Review-Url: https://codereview.chromium.org/2575033002
Cr-Commit-Position: refs/heads/master@{#438483}

[modify] https://crrev.com/c48ca16ce1146ceb5083886cafcef307f46eb8a2/chrome/test/base/tracing_browsertest.cc

Cc: chiniforooshan@chromium.org
Labels: Hotlist-MemoryInfra
Owner: ssid@chromium.org
I learned about this flakiness only 93 mins ago :/
Thanks for disabling. 
I think the recent flakiness is due to https://codereview.chromium.org/2565293003/
Given this I'll paranoidly disable both test on all platforms until we sort this out.

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/135e29eed5ec2fd5acd62a8659ff3b9f07083c63

commit 135e29eed5ec2fd5acd62a8659ff3b9f07083c63
Author: primiano <primiano@chromium.org>
Date: Wed Dec 14 12:43:18 2016

Disable flaky TracingBrowserTest.TestMemoryInfra on all platforms.

Follow up to crrev.com/2575033002
Given the flakyness it's safe to extend the disabling to all platforms
until the source of the flakiness is clarified.

BUG= 658054 

Review-Url: https://codereview.chromium.org/2573063002
Cr-Commit-Position: refs/heads/master@{#438491}

[modify] https://crrev.com/135e29eed5ec2fd5acd62a8659ff3b9f07083c63/chrome/test/base/tracing_browsertest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5b1973c322a9e6bc33dc4a8a2397e8df75d4b4c

commit a5b1973c322a9e6bc33dc4a8a2397e8df75d4b4c
Author: ssid <ssid@chromium.org>
Date: Tue Dec 20 22:27:04 2016

Fix crashes in TracingBrowserTest.TestMemoryInfra

The test may fail if the tracing is stopped before any of the memory
dumps are finished. Now it triggers an explicit memory dump and waits
till it is finished.

BUG= 658054 

Review-Url: https://codereview.chromium.org/2572393002
Cr-Commit-Position: refs/heads/master@{#439893}

[modify] https://crrev.com/a5b1973c322a9e6bc33dc4a8a2397e8df75d4b4c/chrome/test/base/tracing.cc
[modify] https://crrev.com/a5b1973c322a9e6bc33dc4a8a2397e8df75d4b4c/chrome/test/base/tracing.h
[modify] https://crrev.com/a5b1973c322a9e6bc33dc4a8a2397e8df75d4b4c/chrome/test/base/tracing_browsertest.cc

Components: Internals>Instrumentation>Memory
Components: -Internals>Tracing

Comment 10 by ssid@chromium.org, Jan 14 2017

Status: Fixed (was: Assigned)

Sign in to add a comment