New issue
Advanced search Search tips

Issue 658045 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: 2016-10-20
OS: ----
Pri: 2
Type: Bug-Regression
Team-Accessibility



Sign in to add a comment

Programmatic focus on text fields followed by non-programmatic typing yields no accessibility events

Project Member Reported by dtseng@chromium.org, Oct 20 2016

Issue description

STR:
- focus a text field via a call to set focus (translating into focus on an AXObject)
- start typing

result:
no text selection events
 

Comment 1 by dtseng@chromium.org, Oct 20 2016

Labels: -Type-Bug Type-Bug-Regression

Comment 2 by ma...@chromium.org, Oct 21 2016

Cc: dtseng@chromium.org
Since this was reverted [1], the chromevox tests are failing. Can someone have a look? 

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20(1)

[1] https://codereview.chromium.org/2440833002

Comment 3 by dtseng@chromium.org, Oct 21 2016

I'll take a look. There were at least two reverts that touched the same test. Feel free to disable the failing cursorstest. H
Owner: dtseng@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ff29563c5b0619e3722c74af2fe3afa18819999

commit 2ff29563c5b0619e3722c74af2fe3afa18819999
Author: dtseng <dtseng@chromium.org>
Date: Mon Oct 24 18:48:56 2016

Fix editable text selection

We need to special-case setting selections when the focused node is itself editable.
- make no adjustments for the selected node; placing selection outside of the editable content causes key presses to go to the page
- if we are trying to select the entire node, set the selection index to 0 (placing selection at the beginning of the node); otherwise, use the character offset

TEST=move to a text field or content editable via ChromeVox commands; verify typing works to echo the keys. Furthermore, verify that in a content editable with headings, links, etc, jump commands move the selection. Finally, verify ChromeVox text movement commands (e.g. next character), moves selection in single line editables.
BUG= 656349 , 658045 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2442503008
Cr-Commit-Position: refs/heads/master@{#427106}

[modify] https://crrev.com/2ff29563c5b0619e3722c74af2fe3afa18819999/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js

Comment 6 by dtseng@chromium.org, Oct 24 2016

Status: fixed (was: Assigned)

Sign in to add a comment