New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 658039 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
User never visited
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Get Help: fix “Start a Hangout” button in Discover section

Project Member Reported by morsed@google.com, Oct 20 2016

Issue description

To duplicate error: Scroll down in Discover section and click on "Start a Hangout". Nothing happens because link has been broken for a long time. 

The fix will involve the following (as per caseymo@google.com):

Let's link the "Start a Hangout" button to the app or extension in the Web Store, and the "Learn More" button to the Hangouts article. (I'll be deleting the Skype article soon anyway & moving its info into another article.) To be more precise, let's change the "Start a Hangout" link to say "Install Hangouts."


Links (note query string parameter "starthangout") 

Install Hangouts:
https://chrome.google.com/webstore/detail/google-hangouts/knipolnnllmklapflnccelgolnpehhpl?ctx=starthangout (app)

Learn More: 
https://support.google.com/hangouts/answer/6098392?ctx=starthangout 



Eng owner: morsed@
Product owner: weifangsun@ 



 

Comment 1 by morsed@google.com, Oct 21 2016

Description: Show this description
Status: Assigned (was: Untriaged)

Comment 3 by morsed@google.com, Oct 24 2016

Description: Show this description

Comment 4 by morsed@google.com, Oct 24 2016

Description: Show this description

Comment 5 by morsed@google.com, Oct 24 2016

Status: Started (was: Assigned)
Cc: morsed@chromium.org
 Issue 656716  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 8 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-assets/+/8ea1ae8a86ab7534b9e98d55ad9469f0b2532841

commit 8ea1ae8a86ab7534b9e98d55ad9469f0b2532841
Author: David Morse <morsed@google.com>
Date: Wed Nov 02 23:57:54 2016

Comment 8 by morsed@google.com, Nov 8 2016

Labels: Merge-Request-55

Comment 9 by dimu@chromium.org, Nov 9 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 14 2016

Labels: merge-merged-release-R55-8872.B
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-assets/+/26d2244fc27e776fce5ecdd7b6df3d59eabefa7f

commit 26d2244fc27e776fce5ecdd7b6df3d59eabefa7f
Author: David Morse <morsed@google.com>
Date: Wed Nov 02 23:57:54 2016

Comment 11 by morsed@google.com, Nov 15 2016

Status: Fixed (was: Started)
landed in M56 with 8972.0.0/56.0.2907.0

merged into M55 with 8872.52.0/55.0.2883.51
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-assets/+/089ab8c5595be8130f736ce6ce75a5f4cda6fbfc

commit 089ab8c5595be8130f736ce6ce75a5f4cda6fbfc
Author: David Morse <morsed@google.com>
Date: Thu Nov 17 02:08:14 2016

Comment 13 by morsed@google.com, Nov 19 2016

Release note.  The initial code changes already landed for M56, and were merged back to M55, hence the bug being marked fixed.

Translations for the new button text came in later and barely missed M56 branch (landing 9001.0.0/56.0.2923.0/3502314), so translations will require a merge back to M56 and M55. 

Comment 14 by morsed@google.com, Nov 19 2016

Labels: Merge-Request-56 Merge-Request-55
Translations for text update require a mergeback for M56 and a new one for M55 (first mergeback already completed for M55 was for initial code/text changes).  

Cherrypicks made but not yet +2 approved:

M56 https://chrome-internal-review.googlesource.com/#/c/305845/

M55 https://chrome-internal-review.googlesource.com/#/c/305846/  

Comment 15 by morsed@google.com, Nov 19 2016

Status: Started (was: Fixed)

Comment 16 by dimu@chromium.org, Nov 19 2016

Labels: -Merge-Request-55
Your change meets the bar and is auto-approved for M55 (branch: 2883)

Comment 17 by dimu@chromium.org, Nov 19 2016

Labels: -Merge-Request-56 Merge-Approved-56
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 18 by bugdroid1@chromium.org, Nov 21 2016

Labels: merge-merged-release-R56-9000.B
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-assets/+/9c7d483fa4cc0f2307e2a4d4b0068e8b1566bd90

commit 9c7d483fa4cc0f2307e2a4d4b0068e8b1566bd90
Author: David Morse <morsed@google.com>
Date: Thu Nov 17 02:08:14 2016

Project Member

Comment 19 by bugdroid1@chromium.org, Nov 21 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-assets/+/a5a8ae1b25e0e444d04bf05aa84345161bbb79b5

commit a5a8ae1b25e0e444d04bf05aa84345161bbb79b5
Author: David Morse <morsed@google.com>
Date: Thu Nov 17 02:08:14 2016

Project Member

Comment 20 by sheriffbot@chromium.org, Nov 30 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 21 by morsed@google.com, Nov 30 2016

Labels: -Hotlist-Merge-Approved -Merge-Approved-55 -Merge-Approved-56

Comment 22 by morsed@google.com, Jan 18 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment