Hide "submit" button for projects with a CQ (or especially with refs/pending/) |
||
Issue descriptionRietveld doesn't have a submit button. PolyGerrit doesn't need one at first, either. We can hide it until the gnumbd-replacement submit strategy exists.
,
Nov 21 2016
This should be project specific. AFAIK Skia will not use the "gnumbd-replacement submit strategy". Also using the Submit button is great when you do not want the CQ to rerun unnecessarily due to https://bugs.chromium.org/p/chromium/issues/detail?id=634944. The submit button should be controlled by Gerrit ACLs and not hidden by default by commitqueue.js. If we really do want it hidden by default for only chromium then lets make a new chromium specific plugin.
,
Nov 21 2016
Issue gerrit:4972 has been merged into this issue.
,
Nov 21 2016
JS plugins can have configs associated with them (see chumpdetector). I think it makes sense for this as well (even though there is a backend solution coming).
,
Nov 21 2016
Instead of hiding the submit button, would it be possible to make it submit to the CQ for projects that want that behaviour? Would be nice to just hit that instead of having to reply then commit+2 to send to the CQ. For PDFium, we pretty much never submit directly, I hit the submit button thinking it would CQ the change and was quite surprised when it directly committed the change.
,
Nov 21 2016
There will be a more clear UI that looks like this. We need to enable the relevant plugins on your host.
,
Nov 21 2016
Ah, much better, thanks.
,
Jan 12 2017
This is essentially fixed -- we don't want to hide the submit button entirely as it is a good break-glass safety hatch, but it is now demoted to being boring and white. |
||
►
Sign in to add a comment |
||
Comment 1 by aga...@chromium.org
, Nov 10 2016