New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 658028 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Hide "submit" button for projects with a CQ (or especially with refs/pending/)

Project Member Reported by aga...@chromium.org, Oct 20 2016

Issue description

Rietveld doesn't have a submit button. PolyGerrit doesn't need one at first, either. We can hide it until the gnumbd-replacement submit strategy exists.
 

Comment 1 by aga...@chromium.org, Nov 10 2016

Status: Started (was: Assigned)
I've started this here: http://cl/138786033

Comment 2 by rmis...@google.com, Nov 21 2016

This should be project specific. AFAIK Skia will not use the "gnumbd-replacement submit strategy". Also using the Submit button is great when you do not want the CQ to rerun unnecessarily due to https://bugs.chromium.org/p/chromium/issues/detail?id=634944.
The submit button should be controlled by Gerrit ACLs and not hidden by default by commitqueue.js. If we really do want it hidden by default for only chromium then lets make a new chromium specific plugin.
Issue gerrit:4972 has been merged into this issue.
JS plugins can have configs associated with them (see chumpdetector). I think it makes sense for this as well (even though there is a backend solution coming).
Instead of hiding the submit button, would it be possible to make it submit to the CQ for projects that want that behaviour? Would be nice to just hit that instead of having to reply then commit+2 to send to the CQ.

For PDFium, we pretty much never submit directly, I hit the submit button thinking it would CQ the change and was quite surprised when it directly committed the change.
There will be a more clear UI that looks like this. We need to enable the relevant plugins on your host.
Screen Shot 2016-11-21 at 11.28.59 AM.png
264 KB View Download
Ah, much better, thanks.

Comment 8 by aga...@chromium.org, Jan 12 2017

Status: Fixed (was: Started)
This is essentially fixed -- we don't want to hide the submit button entirely as it is a good break-glass safety hatch, but it is now demoted to being boring and white.

Sign in to add a comment