New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 658018 link

Starred by 1 user
Status: Fixed
Owner:
dougt@chromium.org
Closed: Oct 2016
Cc:
█ raymes@chromium.org
mlamouri@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 658020



Sign in to add a comment

Add DCHECKs for thread access to PermissionManager

Project Member Reported by dougt@chromium.org, Oct 20 2016 
Version: ALL
OS: ALL

Currently the permission manager is not thread safe and can be accessed from multiple threads.  Lets add some DCHECKs to notify devs that this is a problem.

Comment 1 by dougt@chromium.org, Oct 20 2016

Blocking: 658020

Comment 2 by benwells@chromium.org, Oct 20 2016

Cc: raymes@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ebc1f3b8cc7caef42f24aad8bd88fe1f9c3856e

commit 0ebc1f3b8cc7caef42f24aad8bd88fe1f9c3856e
Author: dougt <dougt@chromium.org>
Date: Fri Oct 21 15:09:21 2016

Add DCHECKs for thread access PermissionManager.

The PermissionManager is not thread safe. Lets add some DCHECKs to
let us know when there is an unsafe access.

BUG= 658018 

R=jochen

Review-Url: https://chromiumcodereview.appspot.com/2441743003
Cr-Commit-Position: refs/heads/master@{#426793}

[modify] https://crrev.com/0ebc1f3b8cc7caef42f24aad8bd88fe1f9c3856e/chrome/browser/permissions/permission_manager.cc

Comment 5 by dougt@chromium.org, Oct 26 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment