Issue 658014 link

Starred by 1 user

Issue metadata

Status:	Verified
Owner:	glevin@chromium.org
Closed:	Oct 2016
Cc:	alemate@chromium.org achuith@chromium.org
Components:	Services>SignIn
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Bug
VerifyIn-57 VerifyIn-58

Resetting login flow while Back / Close / Reload buttons are disabled leaves them disabled

Project Member Reported by glevin@chromium.org, Oct 20 2016

Issue description

Version: 55.0.2883.7

What steps will reproduce the problem?
(1) At login, bring up a modal dialog
  (e.g. More options > Find my account > Enter phone # and name > "Verify your number" dialog comes up)
(2) Press ESC to reset the login flow (note that this doesn't happen with all modal dialogs)
(3) Notice that the "Reload" button is disabled
(4) Enter email
(5) Notice that the back and close buttons are disabled on Password page

What is the expected output?
The navigation buttons at the top of login pages should generally be enabled unless there's a modal dialog open

What do you see instead?
When login is reset while buttons are disabled, they stay disabled.

In theory, there should probably be no way for this to happen.  See b/20421856 - ESC should just close modal dialogs, not the whole login flow.  Nonetheless, our navigation buttons should behave properly in case it does.

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/652240f3d4404a949aaa0a9ca04017bd25011958

commit 652240f3d4404a949aaa0a9ca04017bd25011958
Author: glevin <glevin@chromium.org>
Date: Fri Oct 28 01:33:24 2016

Fix login navigation button enabling

BUG= 658014 , 660011 
TEST=Back, Close, and Refresh buttons should always be disabled when a
modal dialog is present, and enabled otherwise.  See bugs for specific
repro instructions.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2452333003
Cr-Commit-Position: refs/heads/master@{#428231}

[modify] https://crrev.com/652240f3d4404a949aaa0a9ca04017bd25011958/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js
[modify] https://crrev.com/652240f3d4404a949aaa0a9ca04017bd25011958/chrome/browser/resources/chromeos/login/screen_gaia_signin.js