Issue 658013 link

Starred by 2 users

Issue metadata

Status:	Archived
Owner:	ayatane@chromium.org
Closed:	Nov 2016
Cc:	akes...@chromium.org ayatane@chromium.org █ jrbarnette@chromium.org
Components:	Infra>Client>ChromeOS
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	Bug-Regression
VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

test_that cannot run suites on :lab:

Project Member Reported by briannorris@chromium.org, Oct 20 2016

Issue description

Maybe I'm doing something wrong, but I'm trying to test out a CL here:

https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/paladin/builds/1601

only to find that it didn't run any HWTest stages (b/c the CQ isn't currently configured for that it seems). So I want to specifically use that build to run a test suite on a lab machine. This doesn't seem to work though:


---
$ test_that -b heli -i heli-paladin/R56-8918.0.0-b1601 :lab: suite:bvt-inline
INFO:root:About to start lab suite with command ['/mnt/host/source/src/third_party/autotest/files/site_utils/run_suite.py', '--board', 'heli', '--build', 'heli-paladin/R56-8918.0.0-b1601', '--suite_name', 'test_that_wrapper', '--pool', 'suites', '--max_runtime_mins', '20', '--suite_args', '-b heli -i heli-paladin/R56-8918.0.0-b1601 :lab: suite:bvt-inline'].
usage: run_suite.py [options]
run_suite.py: error: argument --suite_args: expected one argument
---

Am I doing something wrong, or is test_that / run_suite.py buggy?

Comment 1 by briannorris@chromium.org, Oct 20 2016

Cc: akes...@chromium.org jrbarnette@chromium.org ayatane@chromium.org
Labels: -Type-Bug -Pri-3 Pri-2 Type-Bug-Regression

Might be a regression from this CL:

https://chromium-review.googlesource.com/385537

When I checkout the commit before that:

src/third_party/autotest/files/site_utils $ git checkout 93f4db592b1373a6152bce19970d966cec28bb7b^

things work a little better. But I might have a typo -- it should be 'trybot-heli-paladin/...', not 'heli-paladin/...'. Now I have this running:

$ test_that -b heli -i trybot-heli-paladin/R56-8918.0.0-b1601 :lab: suite:bvt-inline
INFO:root:About to start lab suite with command ['/mnt/host/source/src/third_party/autotest/files/site_utils/run_suite.py', '--board', 'heli', '--build', 'trybot-heli-paladin/R56-8918.0.0-b1601', '--suite_name', 'test_that_wrapper', '--pool', 'suites', '--max_runtime_mins', '20', '--suite_args', '-b heli -i trybot-heli-paladin/R56-8918.0.0-b1601 :lab: suite:bvt-inline'].
Autotest instance: cautotest
10-20-2016 [14:23:31] Submitted create_suite_job rpc
10-20-2016 [14:23:44] Created suite job: http://cautotest.corp.google.com/afe/#tab_id=view_job&object_id=81746790
@@@STEP_LINK@Link to suite@http://cautotest.corp.google.com/afe/#tab_id=view_job&object_id=81746790@@@

Comment 2 by jrbarnette@chromium.org, Oct 20 2016

Labels: -Pri-2 Pri-1
Owner: ayatane@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by ayatane@chromium.org, Oct 24 2016

Caused by a subtle bug in parsing: http://bugs.python.org/issue9334

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/910c6042cd2c93e7cfa8e253f96092792600b5be

commit 910c6042cd2c93e7cfa8e253f96092792600b5be
Author: Allen Li <ayatane@chromium.org>
Date: Tue Oct 25 00:52:25 2016

[autotest] Fix argparse handling of arguments starting with dashes

BUG= chromium:658013 
TEST=Run test_that against lab

Change-Id: I98c8682ac6d46e7a3bc0c2aa85e5024915989aef
Reviewed-on: https://chromium-review.googlesource.com/402710
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@google.com>

[modify] https://crrev.com/910c6042cd2c93e7cfa8e253f96092792600b5be/site_utils/run_suite_unittest.py
[modify] https://crrev.com/910c6042cd2c93e7cfa8e253f96092792600b5be/site_utils/test_that.py