New issue
Advanced search Search tips

Issue 658005 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug


Participants' hotlists:
media-router-fixit


Sign in to add a comment

MediaRouterUIBrowserTest.OpenDialogWithMediaRouterAction is flaky

Project Member Reported by ma...@chromium.org, Oct 20 2016

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bceee582fd47e775315f91851ef519a1c463f01b

commit bceee582fd47e775315f91851ef519a1c463f01b
Author: mathp <mathp@chromium.org>
Date: Thu Oct 20 21:14:23 2016

[MediaRouter] Disable MediaRouterUIBrowserTest.OpenDialogWithMediaRouterAction

On all platforms. See bug.

BUG= 658005 
TBR=pkasting
NOTRY=true

Review-Url: https://chromiumcodereview.appspot.com/2439903002
Cr-Commit-Position: refs/heads/master@{#426598}

[modify] https://crrev.com/bceee582fd47e775315f91851ef519a1c463f01b/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc

Comment 2 by mfo...@chromium.org, Oct 26 2016

Components: -Internals>Cast>MediaFling Internals>Cast>UI Tests>Disabled

Comment 3 by mfo...@chromium.org, Oct 27 2016

Status: Available (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9689efb8f5509310872a90a9654b9592cba2d19

commit d9689efb8f5509310872a90a9654b9592cba2d19
Author: takumif <takumif@chromium.org>
Date: Tue Jan 10 20:46:12 2017

Fix the flakiness of MediaRouterUIBrowserTest.OpenDialogWithMediaRouterAction

This browser test was disabled for being flaky; the app menu would not always
open when it was supposed to. This change makes the test wait for the app menu
to open before continuing.

BUG= 658005 

Review-Url: https://codereview.chromium.org/2614413003
Cr-Commit-Position: refs/heads/master@{#442680}

[modify] https://crrev.com/d9689efb8f5509310872a90a9654b9592cba2d19/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc

Status: Fixed (was: Available)
Labels: OS-Chrome OS-Linux OS-Windows
Status: Assigned (was: Fixed)
This is still flaky on Win Linux & Chrome OS:

../../chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc:93: Failure
Value of: app_menu_button->IsMenuShowing()
  Actual: false
Expected: true

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=MediaRouterUIBrowserTest.OpenDialogWithMediaRouterAction&testType=browser_tests
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b1efd5dae551972821f2f6322a32b7a708de9bd

commit 7b1efd5dae551972821f2f6322a32b7a708de9bd
Author: johnme <johnme@chromium.org>
Date: Wed Feb 01 18:23:48 2017

Mark MediaRouterUIBrowserTest.OpenDialogWithMediaRouterAction flaky

on chromeos, linux, win

TBR=apacible@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG= 658005 

Review-Url: https://codereview.chromium.org/2667863005
Cr-Commit-Position: refs/heads/master@{#447557}

[modify] https://crrev.com/7b1efd5dae551972821f2f6322a32b7a708de9bd/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc

Components: Tests>Disabled
Labels: Test-Disabled
Components: Tests>Flaky
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7eed462400adc7478d33776190104ad595879905

commit 7eed462400adc7478d33776190104ad595879905
Author: Peter Kasting <pkasting@chromium.org>
Date: Wed Jan 02 20:42:46 2019

Re-enable disabled tests in chrome/browser/ui/views/media_router/.

These pass on Windows.

This requires (mostly) reverting
https://chromium-review.googlesource.com/c/chromium/src/+/1005103 .
The revert is not perfect since many things changed since that CL
initially landed (e.g. various tests got disabled).

Bug:  658005 , 678472, 817408,  828031 ,  843599 ,  849146 ,  863945 
Change-Id: I23a3010be1faf962e0a2dfbaaa4a57a3e2cc89d3
Reviewed-on: https://chromium-review.googlesource.com/c/1351874
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619483}
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/browser/apps/platform_apps/app_window_interactive_uitest.cc
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/browser/devtools/devtools_sanity_interactive_browsertest.cc
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/browser/extensions/api/tabs/tabs_test.cc
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/browser/notifications/notification_interactive_uitest.cc
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/browser/ui/exclusive_access/fullscreen_controller_test.h
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/browser/ui/keyboard_lock_interactive_browsertest.cc
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/browser/ui/views/media_router/cast_dialog_view_unittest.cc
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/browser/ui/views/media_router/presentation_receiver_window_view_browsertest.cc
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/chrome/test/base/in_process_browser_test.h
[modify] https://crrev.com/7eed462400adc7478d33776190104ad595879905/testing/buildbot/filters/mac_window_server_killers.browser_tests.filter

Status: Fixed (was: Assigned)

Sign in to add a comment