Issue 658001 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	kylec...@chromium.org
Closed:	Nov 2016
Cc:	mustash-bugs@google.com sadrul@chromium.org sky@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	3
Type:	Bug
Proj-Mustash-Mash VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

Run mash_unittests on CrOS Ozone trybot

Project Member Reported by kylec...@chromium.org, Oct 20 2016

Issue description

The mash_unittests target doesn't run on linux_chromium_chromeos_ozone_rel_ng. The tests fail to run under Ozone currently, which I assume is why they weren't added originally.

Comment 1 by kylec...@chromium.org, Nov 23 2016

Cc: sadrul@chromium.org sky@chromium.org
Labels: OS-Chrome
Owner: kylec...@chromium.org
Status: Started (was: Untriaged)
Summary: Run mash_unittests on CrOS Ozone trybot (was: Run mash_unittests on Ozone trybot)

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f1facb2dc43a55f613d8a3ad3111f52c53df203

commit 0f1facb2dc43a55f613d8a3ad3111f52c53df203
Author: kylechar <kylechar@chromium.org>
Date: Thu Nov 24 00:28:20 2016

Enable mash_unittests on CrOS Ozone trybot.

The mash_unittests target would fail running on the CrOS Ozone trybot.
It looks like some broken tests were disabled except if USE_OZONE is
defined. Disable the broken tests for Ozone too and run mash_unittests
on CrOS Ozone trybot.

BUG= 658001 

Review-Url: https://codereview.chromium.org/2517203005
Cr-Commit-Position: refs/heads/master@{#434296}

[modify] https://crrev.com/0f1facb2dc43a55f613d8a3ad3111f52c53df203/ash/mus/app_launch_unittest.cc
[modify] https://crrev.com/0f1facb2dc43a55f613d8a3ad3111f52c53df203/ash/mus/window_manager_unittest.cc
[modify] https://crrev.com/0f1facb2dc43a55f613d8a3ad3111f52c53df203/testing/buildbot/chromium.chromiumos.json