New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 657996 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression

Blocking:
issue 657344



Sign in to add a comment

Regression: SelectWordAroundCaret returns incorrect offsets in wrapped RTL text

Project Member Reported by donnd@chromium.org, Oct 20 2016

Issue description

It looks like there's been a recent regression to the selection range returned in selectWordAroundCaret for RTL text lines that wrap.  See issue for details.

Repro instructions:
1) Go to URL https://goo.gl/KY36Qa
2) Tap on the first line with CS enabled, everything is fine.
3) Tap on one of the wrapped lines, CS sends invalid offsets (start == end) to the server which result in an error.

This CL does some logging and might be helpful: https://codereview.chromium.org/2437193003

Yoshifumi, can you help me assign this to someone to investigate?

 

Comment 1 by yosin@chromium.org, Oct 21 2016

Components: Blink>Editing>Selection
Labels: Needs-Feedback
donnd@, could you attach screenshot of wrapped line? Nobody in editing team can't read Arabic. So, it is helpful to debug. Thanks!

Comment 2 by donnd@chromium.org, Oct 25 2016

Please find logs and Video @ http://go/chrome-androidlogs1/6/657344

Comment 3 by donnd@chromium.org, Oct 25 2016

Also note that the blocking bug has additional information.  Probably the most important part is that this is a regression and the bisect range: https://chromium.googlesource.com/chromium/src/+log/54.0.2840.0..55.0.2841.0?pretty=fuller&n=10000

Comment 4 by donnd@chromium.org, Oct 25 2016

Labels: -Needs-Feedback M-55
This is blocking a bug that is marked RBS for M-55.  I'm not sure it should block the release, but it would be really great to be able to fix this since we don't know how common this problem is.

Comment 5 by yosin@chromium.org, Oct 26 2016

According to the video found in URL of #2, Blink selects word on tap correctly since selection painted as expected.

It seems that WebFrame::textInputInfo() returns wrong value.

Comment 6 by yosin@chromium.org, Dec 2 2016

Owner: ----

Comment 7 by donnd@chromium.org, Jan 12 2017

Cc: twelling...@chromium.org
Labels: -Pri-2 Pri-1
Owner: yosin@chromium.org
Yoshifumi, can you help triage?  Looks like this is in WebFrame::textInputInfo from your comment in #5 but I don't know who would be the best owner to fix this.

Theresa is seeing this a lot now and can add another example from the Google SERP and other pages.
I added a couple of examples to issue 658765

Comment 9 by donnd@chromium.org, Feb 22 2017

Owner: yoichio@chromium.org
Probably related to issue 658765.
Blocking: 658765
Blocking: -658765
Owner: donnd@chromium.org
I went to https://goo.gl/KY36Qa but it looked different from Donn's video:
 it shows pictures first.

Also in the video you call TTS, go to another page and confirm TTS not working on the page. It is redundant. Could you simplify the case?
Since I can't read this kind of RTL langs, I see RTL pages as just 'images'
  then I can't do something like "tap the word <foo in RTL>" 
because I can't recognize "foo" in the RTL lang.

Comment 12 by donnd@chromium.org, Mar 15 2017

Cc: smoha...@etouch.net
Sorry for the lack of information on this bug: this bug is the root cause of another bug filed by an engineer that reads this RTL language.  I'll merge that bug into this one.

Comment 13 by donnd@chromium.org, Mar 15 2017

Issue 657344 has been merged into this issue.

Comment 14 by donnd@chromium.org, Mar 15 2017

smohanty@etouch.net, can you help with the requests in #11?
Re #14, I am not able to reproduce 657344 this issue anymore on latest M58-58.0.3029.23 and M59-59.0.3042.0 . Hence, I am not able to simply this case. 

Sign in to add a comment