New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 657993 link

Starred by 5 users
Status: Duplicate
Merged: issue 384330
Owner:
█ bmcquade@chromium.org
Last visit > 30 days ago
Closed: Oct 2016
Cc:
█ wiltzius@chromium.org
█ pmeenan@chromium.org
rbyers@chromium.org
csharrison@chromium.org
█ rtenneti@chromium.org
█ darin@chromium.org
█ jar@chromium.org
pasko@chromium.org
█ tonyg@chromium.org
█ andrewhayden@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

remove page_load_histograms and any dead code that results

Project Member Reported by bmcquade@chromium.org, Oct 20 2016 
We're getting ready to remove page_load_histograms.h/.cc.

As part of that work, we can remove code that will be dead as a result of these files going away.

For example, the following properties in DocumentState are only needed by page_load_histograms:
web_timing_histograms_recorded
load_histograms_recorded
commit_load_time
first_paint_time
first_paint_after_load_time
finish_load_time
load_type

extensions::Dispatcher::WasWebRequestUsedBySomeExtensions can be removed

RenderThread::UpdateHistograms can be removed

Comment 1 by bmcquade@chromium.org, Oct 21 2016 

Issue 623817 has been merged into this issue.
Issue 627321 has been merged into this issue.
Issue 627323 has been merged into this issue.
Issue 627326 has been merged into this issue.
Issue 627327 has been merged into this issue.
Issue 627328 has been merged into this issue.
Issue 627329 has been merged into this issue.
Issue 629388 has been merged into this issue.
Issue 629393 has been merged into this issue.

Comment 2 by bmcquade@chromium.org, Oct 21 2016

Cc: pmeenan@chromium.org wiltzius@chromium.org
 Issue 392169  has been merged into this issue.

Comment 3 by bmcquade@chromium.org, Oct 21 2016

Cc: rbyers@chromium.org pasko@chromium.org andrewhayden@chromium.org rtenneti@chromium.org jar@chromium.org tonyg@chromium.org darin@chromium.org
 Issue 321236  has been merged into this issue.

Comment 4 by bmcquade@chromium.org, Oct 21 2016

Mergedinto: 384330
Status: Duplicate (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f070c52d32c8884c5ffc39cab50ca6cc7cb02bf

commit 1f070c52d32c8884c5ffc39cab50ca6cc7cb02bf
Author: bmcquade <bmcquade@chromium.org>
Date: Wed Nov 02 17:50:51 2016

Remove dead paint flush tracking code.

In https://codereview.chromium.org/2437863005, page_load_histograms,
which was the only consumer of this code, was removed. Now that the
page_load_histograms code has been removed, this code can be removed as
well.

BUG= 657993 

Review-Url: https://codereview.chromium.org/2448543002
Cr-Commit-Position: refs/heads/master@{#429329}

[modify] https://crrev.com/1f070c52d32c8884c5ffc39cab50ca6cc7cb02bf/content/public/renderer/document_state.h
[modify] https://crrev.com/1f070c52d32c8884c5ffc39cab50ca6cc7cb02bf/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/1f070c52d32c8884c5ffc39cab50ca6cc7cb02bf/content/renderer/render_view_impl.cc
[modify] https://crrev.com/1f070c52d32c8884c5ffc39cab50ca6cc7cb02bf/content/renderer/render_view_impl.h
[modify] https://crrev.com/1f070c52d32c8884c5ffc39cab50ca6cc7cb02bf/content/renderer/render_widget.cc
[modify] https://crrev.com/1f070c52d32c8884c5ffc39cab50ca6cc7cb02bf/content/renderer/render_widget.h
[modify] https://crrev.com/1f070c52d32c8884c5ffc39cab50ca6cc7cb02bf/content/renderer/render_widget_fullscreen_pepper.cc
[modify] https://crrev.com/1f070c52d32c8884c5ffc39cab50ca6cc7cb02bf/content/renderer/render_widget_fullscreen_pepper.h
[modify] https://crrev.com/1f070c52d32c8884c5ffc39cab50ca6cc7cb02bf/content/renderer/render_widget_owner_delegate.h
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d48284c61aefddb82c657751c59d4a32e5b4fd3c

commit d48284c61aefddb82c657751c59d4a32e5b4fd3c
Author: bmcquade <bmcquade@chromium.org>
Date: Wed Nov 02 18:18:40 2016

Remove dead flush histograms code.

In https://codereview.chromium.org/2437863005, page_load_histograms,
which was the only consumer of this code, was removed. Now that the
page_load_histograms code has been removed, this code can be removed as
well.

This change is also a follow up to https://codereview.chromium.org/2231843002,
which disabled histogram flushing when persistence was enabled. Now that
page_load_histograms is gone, we can remove the flushing logic entirely.

BUG= 657993 

Review-Url: https://codereview.chromium.org/2446533003
Cr-Commit-Position: refs/heads/master@{#429346}

[modify] https://crrev.com/d48284c61aefddb82c657751c59d4a32e5b4fd3c/content/child/child_histogram_message_filter.cc
[modify] https://crrev.com/d48284c61aefddb82c657751c59d4a32e5b4fd3c/content/child/child_histogram_message_filter.h
[modify] https://crrev.com/d48284c61aefddb82c657751c59d4a32e5b4fd3c/content/public/renderer/render_thread.h
[modify] https://crrev.com/d48284c61aefddb82c657751c59d4a32e5b4fd3c/content/public/test/mock_render_thread.cc
[modify] https://crrev.com/d48284c61aefddb82c657751c59d4a32e5b4fd3c/content/public/test/mock_render_thread.h
[modify] https://crrev.com/d48284c61aefddb82c657751c59d4a32e5b4fd3c/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/d48284c61aefddb82c657751c59d4a32e5b4fd3c/content/renderer/render_thread_impl.h
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69722fddd0f46c528986bfc87897b0f1607e1f26

commit 69722fddd0f46c528986bfc87897b0f1607e1f26
Author: bmcquade <bmcquade@chromium.org>
Date: Wed Nov 02 22:15:38 2016

Remove dead extensions tracking code.

In https://codereview.chromium.org/2437863005, page_load_histograms,
which was the only consumer of this code, was removed. Now that the
page_load_histograms code has been removed, this code can be removed as
well.

BUG= 657993 

Review-Url: https://codereview.chromium.org/2442213003
Cr-Commit-Position: refs/heads/master@{#429418}

[modify] https://crrev.com/69722fddd0f46c528986bfc87897b0f1607e1f26/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc
[modify] https://crrev.com/69722fddd0f46c528986bfc87897b0f1607e1f26/extensions/browser/api/declarative_webrequest/webrequest_rules_registry.cc
[modify] https://crrev.com/69722fddd0f46c528986bfc87897b0f1607e1f26/extensions/browser/api/web_request/web_request_api.cc
[modify] https://crrev.com/69722fddd0f46c528986bfc87897b0f1607e1f26/extensions/browser/api/web_request/web_request_api_helpers.cc
[modify] https://crrev.com/69722fddd0f46c528986bfc87897b0f1607e1f26/extensions/browser/api/web_request/web_request_api_helpers.h
[modify] https://crrev.com/69722fddd0f46c528986bfc87897b0f1607e1f26/extensions/browser/runtime_data.cc
[modify] https://crrev.com/69722fddd0f46c528986bfc87897b0f1607e1f26/extensions/browser/runtime_data.h
[modify] https://crrev.com/69722fddd0f46c528986bfc87897b0f1607e1f26/extensions/browser/runtime_data_unittest.cc
[modify] https://crrev.com/69722fddd0f46c528986bfc87897b0f1607e1f26/extensions/common/extension_messages.h
[modify] https://crrev.com/69722fddd0f46c528986bfc87897b0f1607e1f26/extensions/renderer/dispatcher.cc
[modify] https://crrev.com/69722fddd0f46c528986bfc87897b0f1607e1f26/extensions/renderer/dispatcher.h
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49550fef9418c915f8d73ac8ea768d729c0b31c8

commit 49550fef9418c915f8d73ac8ea768d729c0b31c8
Author: bmcquade <bmcquade@chromium.org>
Date: Thu Nov 03 18:03:52 2016

Remove dead DocumentState metrics tracking code

In https://codereview.chromium.org/2437863005, page_load_histograms,
which was the only consumer of this code, was removed. Now that the
page_load_histograms code has been removed, this code can be removed as
well.

BUG= 657993 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2449553002
Cr-Commit-Position: refs/heads/master@{#429646}

[modify] https://crrev.com/49550fef9418c915f8d73ac8ea768d729c0b31c8/components/test_runner/web_frame_test_client.cc
[modify] https://crrev.com/49550fef9418c915f8d73ac8ea768d729c0b31c8/components/test_runner/web_frame_test_client.h
[modify] https://crrev.com/49550fef9418c915f8d73ac8ea768d729c0b31c8/components/test_runner/web_frame_test_proxy.h
[modify] https://crrev.com/49550fef9418c915f8d73ac8ea768d729c0b31c8/content/browser/frame_host/navigation_entry_impl.cc
[modify] https://crrev.com/49550fef9418c915f8d73ac8ea768d729c0b31c8/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/49550fef9418c915f8d73ac8ea768d729c0b31c8/content/common/frame_messages.h
[modify] https://crrev.com/49550fef9418c915f8d73ac8ea768d729c0b31c8/content/common/navigation_params.cc
[modify] https://crrev.com/49550fef9418c915f8d73ac8ea768d729c0b31c8/content/common/navigation_params.h
[modify] https://crrev.com/49550fef9418c915f8d73ac8ea768d729c0b31c8/content/public/renderer/document_state.cc
[modify] https://crrev.com/49550fef9418c915f8d73ac8ea768d729c0b31c8/content/public/renderer/document_state.h
[modify] https://crrev.com/49550fef9418c915f8d73ac8ea768d729c0b31c8/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/49550fef9418c915f8d73ac8ea768d729c0b31c8/content/renderer/render_frame_impl.h
[modify] https://crrev.com/49550fef9418c915f8d73ac8ea768d729c0b31c8/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/49550fef9418c915f8d73ac8ea768d729c0b31c8/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/49550fef9418c915f8d73ac8ea768d729c0b31c8/third_party/WebKit/Source/core/loader/FrameLoaderClient.h
[modify] https://crrev.com/49550fef9418c915f8d73ac8ea768d729c0b31c8/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
[modify] https://crrev.com/49550fef9418c915f8d73ac8ea768d729c0b31c8/third_party/WebKit/Source/web/FrameLoaderClientImpl.h
[modify] https://crrev.com/49550fef9418c915f8d73ac8ea768d729c0b31c8/third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp
[modify] https://crrev.com/49550fef9418c915f8d73ac8ea768d729c0b31c8/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
[modify] https://crrev.com/49550fef9418c915f8d73ac8ea768d729c0b31c8/third_party/WebKit/public/web/WebFrameClient.h
►

Sign in to add a comment