failure to import client/common_lib/site_utils, in prod |
||||||||
Issue description
Trying to run a recently added script in the production environment, I ran into:
chromeos-test@chromeos-server2:/usr/local/autotest/site_utils$ ./dump_suite_report.py -h
Traceback (most recent call last):
File "./dump_suite_report.py", line 13, in <module>
from autotest_lib.server.lib import suite_report
File "/usr/local/autotest/server/lib/suite_report.py", line 13, in <module>
from autotest_lib.server import frontend
File "/usr/local/autotest/server/frontend.py", line 23, in <module>
from autotest_lib.frontend.afe import rpc_client_lib
File "/usr/local/autotest/frontend/afe/rpc_client_lib.py", line 10, in <module>
from autotest_lib.client.common_lib import utils
File "/usr/local/autotest/client/common_lib/utils.py", line 14, in <module>
from autotest_lib.client.common_lib.site_utils import *
File "/usr/local/autotest/client/common_lib/site_utils.py", line 49, in <module>
ip, mask_bits = subnet.split('/') if '/' in subnet else subnet.split(':')
ValueError: too many values to unpack
The relevant code in site_utils.py is:
# TODO(dshi): Remove the code to split subnet with `:` after R51 is off stable
# channel, and update shadow config to use `/` as delimiter for consistency.
for subnet in restricted_subnets_list:
ip, mask_bits = subnet.split('/') if '/' in subnet else subnet.split(':')
RESTRICTED_SUBNETS.append((ip, int(mask_bits)))
Dan your name is on that TODO. Any idea what is going on?
,
Oct 20 2016
Oh looks like you're already fixing this.
,
Oct 20 2016
yes, fix was in https://chrome-internal-review.googlesource.com/#/c/298516/
,
Jan 21 2017
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by akes...@chromium.org
, Oct 20 2016