New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 657972 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Update <ol>.start getter to default to 1

Project Member Reported by domenic@chromium.org, Oct 20 2016

Issue description

Currently in Edge and Firefox, <ol>.start defaults to 1. In Chrome and WebKit, it defaults to something that depends on how many children are rendered. In https://github.com/whatwg/html/pull/1916 we updated the spec to follow the simpler Firefox/Edge behavior, with tkent@'s support. We should implement this change.

Tests are available at http://w3c-test.org/html/semantics/grouping-content/the-ol-element/grouping-ol.html
 

Comment 1 by tkent@chromium.org, Oct 20 2016

Labels: Hotlist-Interop
Status: Available (was: Untriaged)
We should add a UseCounter first to evaluate a risk.

Comment 2 by foolip@chromium.org, Nov 11 2016

Owner: lunalu@chromium.org
Status: Assigned (was: Available)
lunalu@, this seems like a small and contained change in a new area for you. I would suggest first preparing a CL that makes the test pass, then it'll be easier to judge what the risk involved is, and if we indeed need use counters first.

Comment 3 by foolip@chromium.org, Nov 11 2016

On second thought, this actually isn't IDL-related, was a bit quick on the trigger there.

Comment 4 by foolip@chromium.org, Nov 11 2016

Owner: ----
Status: Available (was: Assigned)
Owner: shanmug...@samsung.com
Status: Assigned (was: Available)
Only the test cases which are related to "reversed", are failed.
Do we need to add usecounter for specific to this case ? Or can I make CL to pass the tests pass ?

Comment 7 by tkent@chromium.org, May 24 2017

#6,
We should count |start| IDL getter with |reversed| attribute and no |start| content attribute.
I don't recommend to make a bahavior change CL yet.

Project Member

Comment 8 by bugdroid1@chromium.org, May 25 2017

Comment 9 by tkent@chromium.org, May 25 2017

NextAction: 2017-08-08
Wait for the UseCounter data.

The NextAction date has arrived: 2017-08-08
NextAction: ----
The counter: https://www.chromestatus.com/metrics/feature/timeline/popularity/2011

IMO, we may skip intent-to-ship process though a chromestatus.com entry is necessary.

Project Member

Comment 13 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b676f1bd0267ee1a3f189a17567f8f7d10a15a0

commit 8b676f1bd0267ee1a3f189a17567f8f7d10a15a0
Author: Shanmuga Pandi M <shanmuga.m@samsung.com>
Date: Tue Aug 22 09:41:17 2017

Update <ol>.start getter to default to 1.

Spec:
https://html.spec.whatwg.org/multipage/grouping-content.html#dom-ol-start

Bug:  657972 
Change-Id: I13da4bcb8d65d428b6b671fa1c44003c7901a164
Reviewed-on: https://chromium-review.googlesource.com/618215
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496261}
[delete] https://crrev.com/648a03cbb08c558d675d8530a124d52324506454/third_party/WebKit/LayoutTests/external/wpt/html/semantics/grouping-content/the-ol-element/grouping-ol-expected.txt
[delete] https://crrev.com/648a03cbb08c558d675d8530a124d52324506454/third_party/WebKit/LayoutTests/external/wpt/html/semantics/grouping-content/the-ol-element/ol.start-reflection-2-expected.txt
[modify] https://crrev.com/8b676f1bd0267ee1a3f189a17567f8f7d10a15a0/third_party/WebKit/LayoutTests/fast/lists/ol-reversed-simple-expected.txt
[modify] https://crrev.com/8b676f1bd0267ee1a3f189a17567f8f7d10a15a0/third_party/WebKit/LayoutTests/fast/lists/ol-reversed-simple-xhtml-expected.txt
[modify] https://crrev.com/8b676f1bd0267ee1a3f189a17567f8f7d10a15a0/third_party/WebKit/Source/core/html/HTMLOListElement.cpp
[modify] https://crrev.com/8b676f1bd0267ee1a3f189a17567f8f7d10a15a0/third_party/WebKit/Source/core/html/HTMLOListElement.h
[modify] https://crrev.com/8b676f1bd0267ee1a3f189a17567f8f7d10a15a0/third_party/WebKit/Source/core/layout/LayoutCounter.cpp
[modify] https://crrev.com/8b676f1bd0267ee1a3f189a17567f8f7d10a15a0/third_party/WebKit/Source/core/layout/LayoutListItem.cpp
[modify] https://crrev.com/8b676f1bd0267ee1a3f189a17567f8f7d10a15a0/third_party/WebKit/public/platform/web_feature.mojom
[modify] https://crrev.com/8b676f1bd0267ee1a3f189a17567f8f7d10a15a0/tools/metrics/histograms/enums.xml

Comment 14 by tkent@chromium.org, Aug 22 2017

Labels: M-62
Status: Fixed (was: Assigned)

Sign in to add a comment