New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 657960 link

Starred by 1 user
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Oct 2016
Cc:
tbuck...@chromium.org
bettes@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 614588



Sign in to add a comment

[Content settings] Use toggle buttons in site list subpage

Project Member Reported by dschuyler@chromium.org, Oct 20 2016 
In chrome://md-settings/siteSettings
The checkboxes should change to toggle buttons.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/151575ce0bb6fc26a3381c029fccc3c0ec5bfda0

commit 151575ce0bb6fc26a3381c029fccc3c0ec5bfda0
Author: dschuyler <dschuyler@chromium.org>
Date: Fri Oct 21 00:56:10 2016

[MD settings] content site list toggles

This CL makes the boolean settings in the content settings site list
subpage. Also adds the settings-boolean-control-behavior.

BUG= 657960 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://chromiumcodereview.appspot.com/2437183002
Cr-Commit-Position: refs/heads/master@{#426666}

[modify] https://crrev.com/151575ce0bb6fc26a3381c029fccc3c0ec5bfda0/chrome/browser/resources/settings/controls/compiled_resources2.gyp
[add] https://crrev.com/151575ce0bb6fc26a3381c029fccc3c0ec5bfda0/chrome/browser/resources/settings/controls/settings_boolean_control_behavior.html
[add] https://crrev.com/151575ce0bb6fc26a3381c029fccc3c0ec5bfda0/chrome/browser/resources/settings/controls/settings_boolean_control_behavior.js
[modify] https://crrev.com/151575ce0bb6fc26a3381c029fccc3c0ec5bfda0/chrome/browser/resources/settings/controls/settings_checkbox.html
[modify] https://crrev.com/151575ce0bb6fc26a3381c029fccc3c0ec5bfda0/chrome/browser/resources/settings/controls/settings_checkbox.js
[add] https://crrev.com/151575ce0bb6fc26a3381c029fccc3c0ec5bfda0/chrome/browser/resources/settings/controls/settings_toggle_button.html
[add] https://crrev.com/151575ce0bb6fc26a3381c029fccc3c0ec5bfda0/chrome/browser/resources/settings/controls/settings_toggle_button.js
[modify] https://crrev.com/151575ce0bb6fc26a3381c029fccc3c0ec5bfda0/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/151575ce0bb6fc26a3381c029fccc3c0ec5bfda0/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/151575ce0bb6fc26a3381c029fccc3c0ec5bfda0/chrome/browser/resources/settings/site_settings/site_settings_category.html
[modify] https://crrev.com/151575ce0bb6fc26a3381c029fccc3c0ec5bfda0/chrome/test/data/webui/settings/cr_settings_browsertest.js
[add] https://crrev.com/151575ce0bb6fc26a3381c029fccc3c0ec5bfda0/chrome/test/data/webui/settings/settings_toggle_button_tests.js

Comment 2 by dschuyler@chromium.org, Oct 21 2016

Status: Fixed (was: Started)
►

Sign in to add a comment