hwi@, do we have the exact DPs for the spacing between fields?

go/02-input-text-png-folio

Please DO let me know for any clarifications and questions. I'm sure something may be missing in the spec although I tried not to =)

Thanks!

Here are updated screens, what do you think hwi@

Deleted: Screenshot_2016-10-26-16-57-55.png 128 KB

	Screenshot_2016-10-26-16-57-55.png 128 KB View Download

Deleted: Screenshot_2016-10-26-16-58-20.png 134 KB

	Screenshot_2016-10-26-16-58-20.png 134 KB View Download

Deleted: Screenshot_2016-10-26-16-58-08.png 84.1 KB

	Screenshot_2016-10-26-16-58-08.png 84.1 KB View Download

What do validation error messages on text fields look like?

It will add additional space since it is a push down message,

Deleted: Screenshot_2016-10-26-17-09-22.png 130 KB

	Screenshot_2016-10-26-17-09-22.png 130 KB View Download

Thanks for working on this, gogerald@! 

Please see the attachments. 

Deleted: add addr.png 130 KB

	add addr.png 130 KB View Download

Deleted: edit card.png 210 KB

	edit card.png 210 KB View Download

Deleted: add card.png 211 KB

	add card.png 211 KB View Download

Shall we also short the title 'Add credit card' to 'Add card'?

c8: Yes. Thanks!

Hi Hwi@, here is the updated screens with correct top padding and title.

The error icon in the dropdown field is Android asset (default way to show error for text). Technically we can implement our own way to show error like text field above which is also Android default layout.

The underline color in the edit text field is a theme (color: 5A5A5A) color used across the app. Technically we could change it only edit text field in payments.

All above need more engineering effort, I would like do it separately, especially the spacing problem looks more important and we want it in M55. Do you think this sounds good?

Deleted: Screenshot_2016-10-27-13-31-20.png 131 KB

	Screenshot_2016-10-27-13-31-20.png 131 KB View Download

Deleted: Screenshot_2016-10-27-13-31-28.png 132 KB

	Screenshot_2016-10-27-13-31-28.png 132 KB View Download

Deleted: Screenshot_2016-10-27-13-31-36.png 82.9 KB

	Screenshot_2016-10-27-13-31-36.png 82.9 KB View Download

Deleted: Screenshot_2016-10-27-13-31-42.png 87.2 KB

	Screenshot_2016-10-27-13-31-42.png 87.2 KB View Download

c#10 Top padding - LGTM & Separate plan for general style fix - SGTM. Thanks!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d062f24e1ede7485051d12eea9909f24c453362

commit 6d062f24e1ede7485051d12eea9909f24c453362
Author: gogerald <gogerald@chromium.org>
Date: Fri Oct 28 02:17:03 2016

Increase spacing for payment request credit card and address editors

This CL also adds cards icon border and changes the cardEditor title.

BUG= 657178 ,  657952 

Review-Url: https://codereview.chromium.org/2450113003
Cr-Commit-Position: refs/heads/master@{#428247}

[modify] https://crrev.com/6d062f24e1ede7485051d12eea9909f24c453362/chrome/android/java/res/layout/payment_request_editor.xml
[modify] https://crrev.com/6d062f24e1ede7485051d12eea9909f24c453362/chrome/android/java/res/layout/payment_request_editor_dropdown.xml
[modify] https://crrev.com/6d062f24e1ede7485051d12eea9909f24c453362/chrome/android/java/res/layout/payment_request_editor_icons.xml
[modify] https://crrev.com/6d062f24e1ede7485051d12eea9909f24c453362/chrome/android/java/res/layout/payments_request_editor_textview.xml
[modify] https://crrev.com/6d062f24e1ede7485051d12eea9909f24c453362/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
[modify] https://crrev.com/6d062f24e1ede7485051d12eea9909f24c453362/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorIconsField.java
[modify] https://crrev.com/6d062f24e1ede7485051d12eea9909f24c453362/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/SectionInformation.java
[modify] https://crrev.com/6d062f24e1ede7485051d12eea9909f24c453362/chrome/android/java/strings/android_chrome_strings.grd

Would like to merge https://crrev.com/6d062f24e1ede7485051d12eea9909f24c453362 to M-55.

Your change meets the bar and is auto-approved for M55 (branch: 2883)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3d44f7512a3002ebd2583e585e3a13a4e5b0011

commit f3d44f7512a3002ebd2583e585e3a13a4e5b0011
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Tue Nov 01 22:25:39 2016

[Merge M-55] Increase spacing for payment request credit card and address editors

This CL also adds cards icon border and changes the cardEditor title.

BUG= 657178 ,  657952 

Review-Url: https://codereview.chromium.org/2450113003
Cr-Commit-Position: refs/heads/master@{#428247}
(cherry picked from commit 6d062f24e1ede7485051d12eea9909f24c453362)

Review URL: https://codereview.chromium.org/2463293005 .

Cr-Commit-Position: refs/branch-heads/2883@{#412}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/f3d44f7512a3002ebd2583e585e3a13a4e5b0011/chrome/android/java/res/layout/payment_request_editor.xml
[modify] https://crrev.com/f3d44f7512a3002ebd2583e585e3a13a4e5b0011/chrome/android/java/res/layout/payment_request_editor_dropdown.xml
[modify] https://crrev.com/f3d44f7512a3002ebd2583e585e3a13a4e5b0011/chrome/android/java/res/layout/payment_request_editor_icons.xml
[modify] https://crrev.com/f3d44f7512a3002ebd2583e585e3a13a4e5b0011/chrome/android/java/res/layout/payments_request_editor_textview.xml
[modify] https://crrev.com/f3d44f7512a3002ebd2583e585e3a13a4e5b0011/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
[modify] https://crrev.com/f3d44f7512a3002ebd2583e585e3a13a4e5b0011/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorIconsField.java
[modify] https://crrev.com/f3d44f7512a3002ebd2583e585e3a13a4e5b0011/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/SectionInformation.java
[modify] https://crrev.com/f3d44f7512a3002ebd2583e585e3a13a4e5b0011/chrome/android/java/strings/android_chrome_strings.grd