2D Canvas with colorspace linear-rgb does not display |
|||||||
Issue descriptionSteps to repro: In ToT chrome (after https://codereview.chromium.org/2425113002/ lands) 1. in chrome://flags, enable "Experimental canvas features" 2. restart the browser 3. create a canvas context with getContext('2d', {colorSpace:'linear-rgb'}) 4. draw to the canvas context Result: canvas contents are not displayed
,
Oct 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5d3239d0abd54d3a4d37ae15c6cccd92f6122d0 commit a5d3239d0abd54d3a4d37ae15c6cccd92f6122d0 Author: zakerinasab <zakerinasab@chromium.org> Date: Tue Oct 25 18:50:36 2016 Adding browser pixel test for linear-rgb support in Canvas. Recetnly the proper plumbing has been added to Canvas such that it renders when linear-rgb color space is used (codereview.chromium.org/2425113002/). This change adds a browser pixel test to see if the rendered Canvas is properly displayed. BUG= 657946 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2448583002 Cr-Commit-Position: refs/heads/master@{#427425} [add] https://crrev.com/a5d3239d0abd54d3a4d37ae15c6cccd92f6122d0/content/test/data/gpu/pixel_canvas_display_linear-rgb.html [modify] https://crrev.com/a5d3239d0abd54d3a4d37ae15c6cccd92f6122d0/content/test/gpu/gpu_tests/pixel_expectations.py [modify] https://crrev.com/a5d3239d0abd54d3a4d37ae15c6cccd92f6122d0/content/test/gpu/gpu_tests/pixel_test_pages.py
,
Oct 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8009581cb30fdf146a6bd48aa77605a7a7a43096 commit 8009581cb30fdf146a6bd48aa77605a7a7a43096 Author: zakerinasab <zakerinasab@chromium.org> Date: Fri Oct 28 21:33:07 2016 Fixing timeout in pixel_canvas_display_linear-rgb browser pixel test Addressing the timeout bug in browser pixel test of codereview.chromium.org/2448583002/ BUG= 657946 Review-Url: https://codereview.chromium.org/2457113002 Cr-Commit-Position: refs/heads/master@{#428498} [modify] https://crrev.com/8009581cb30fdf146a6bd48aa77605a7a7a43096/content/test/data/gpu/pixel_canvas_display_linear-rgb.html
,
Nov 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fefddce5c498187b4d9a2f721d489ab82c7154c5 commit fefddce5c498187b4d9a2f721d489ab82c7154c5 Author: zakerinasab <zakerinasab@chromium.org> Date: Tue Nov 01 18:59:53 2016 Removing self.Fails of browser pixel tests from pixel_expectations.py. As all the results on cloud storage bucket are as expected, we can remove the self.Fails lines from pixel_expectations.py. BUG= 657946 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2459373002 Cr-Commit-Position: refs/heads/master@{#429065} [modify] https://crrev.com/fefddce5c498187b4d9a2f721d489ab82c7154c5/content/test/gpu/gpu_tests/pixel_expectations.py
,
Nov 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/271fcfdf7bf79791d621a048cdacd98e708a495b commit 271fcfdf7bf79791d621a048cdacd98e708a495b Author: ynovikov <ynovikov@chromium.org> Date: Wed Nov 02 00:44:41 2016 Skip Pixel_CanvasDisplayLinearRGBUnaccelerated2D on Android Because it uses software compositing which is not supported on Android. Enabled in https://codereview.chromium.org/2459373002 by mistake. BUG= 657946 , 563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2473573002 Cr-Commit-Position: refs/heads/master@{#429164} [modify] https://crrev.com/271fcfdf7bf79791d621a048cdacd98e708a495b/content/test/gpu/gpu_tests/pixel_expectations.py
,
Nov 2 2016
,
Nov 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/707a5decdda5d9ee767c84f4b7f4b3eddea8cb7e commit 707a5decdda5d9ee767c84f4b7f4b3eddea8cb7e Author: zakerinasab <zakerinasab@chromium.org> Date: Wed Nov 02 18:11:11 2016 Fixing timeout in pixel_canvas_display_linear-rgb browser pixel test Addressing the timeout bug in browser pixel test of codereview.chromium.org/2448583002/ BUG= 657946 Committed: https://crrev.com/8009581cb30fdf146a6bd48aa77605a7a7a43096 Review-Url: https://codereview.chromium.org/2457113002 Cr-Original-Commit-Position: refs/heads/master@{#428498} Cr-Commit-Position: refs/heads/master@{#429343} [modify] https://crrev.com/707a5decdda5d9ee767c84f4b7f4b3eddea8cb7e/content/test/data/gpu/pixel_canvas_display_linear-rgb.html
,
Nov 2 2016
,
Nov 2 2016
As discussed, this is not really fixed. Re-opnening.
,
Nov 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b074f5f0a72f308e79120570fd3da24263f217c9 commit b074f5f0a72f308e79120570fd3da24263f217c9 Author: ccameron <ccameron@chromium.org> Date: Wed Nov 16 08:35:03 2016 Add more robust gfx::ColorSpace<->gfx::ICCProfile conversion When a gfx::ICCProfile is created from a gfx::ColorSpace, store the original gfx::ColorSpace that it was created from, so that when gfx::ICCProfile::GetColorSpace is called, we can return the exact same original object. BUG= 657946 Review-Url: https://codereview.chromium.org/2502703002 Cr-Commit-Position: refs/heads/master@{#432430} [modify] https://crrev.com/b074f5f0a72f308e79120570fd3da24263f217c9/ui/gfx/color_space.cc [modify] https://crrev.com/b074f5f0a72f308e79120570fd3da24263f217c9/ui/gfx/icc_profile.cc [modify] https://crrev.com/b074f5f0a72f308e79120570fd3da24263f217c9/ui/gfx/icc_profile.h [modify] https://crrev.com/b074f5f0a72f308e79120570fd3da24263f217c9/ui/gfx/ipc/color/gfx_param_traits_macros.h [modify] https://crrev.com/b074f5f0a72f308e79120570fd3da24263f217c9/ui/gfx/mojo/BUILD.gn [add] https://crrev.com/b074f5f0a72f308e79120570fd3da24263f217c9/ui/gfx/mojo/color_space.mojom [add] https://crrev.com/b074f5f0a72f308e79120570fd3da24263f217c9/ui/gfx/mojo/color_space.typemap [modify] https://crrev.com/b074f5f0a72f308e79120570fd3da24263f217c9/ui/gfx/mojo/icc_profile.mojom [modify] https://crrev.com/b074f5f0a72f308e79120570fd3da24263f217c9/ui/gfx/mojo/icc_profile.typemap [modify] https://crrev.com/b074f5f0a72f308e79120570fd3da24263f217c9/ui/gfx/mojo/icc_profile_struct_traits.cc [modify] https://crrev.com/b074f5f0a72f308e79120570fd3da24263f217c9/ui/gfx/mojo/icc_profile_struct_traits.h
,
Nov 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1837b16f64c579bc60b2e3ae512de9ee75f36836 commit 1837b16f64c579bc60b2e3ae512de9ee75f36836 Author: zakerinasab <zakerinasab@chromium.org> Date: Fri Nov 18 17:40:22 2016 Display linear-srgb color managed canvas When the canvas is tagged with linear-tgb color space, it is not displayed. This CL fixes this problem for software path and accelerated path and also the layout tests. BUG= 657946 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2496913003 Cr-Commit-Position: refs/heads/master@{#433229} [modify] https://crrev.com/1837b16f64c579bc60b2e3ae512de9ee75f36836/cc/resources/resource_provider.cc [modify] https://crrev.com/1837b16f64c579bc60b2e3ae512de9ee75f36836/content/browser/web_contents/web_contents_view_aura.cc [modify] https://crrev.com/1837b16f64c579bc60b2e3ae512de9ee75f36836/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/1837b16f64c579bc60b2e3ae512de9ee75f36836/third_party/WebKit/LayoutTests/VirtualTestSuites [delete] https://crrev.com/8934714bb524f1a32b6d5434fea0ac59660cf6ff/third_party/WebKit/LayoutTests/fast/canvas/canvas-colorSpace-attribute.html [add] https://crrev.com/1837b16f64c579bc60b2e3ae512de9ee75f36836/third_party/WebKit/LayoutTests/fast/canvas/color-space/display_linear-rgb-expected.html [add] https://crrev.com/1837b16f64c579bc60b2e3ae512de9ee75f36836/third_party/WebKit/LayoutTests/fast/canvas/color-space/display_linear-rgb.html [add] https://crrev.com/1837b16f64c579bc60b2e3ae512de9ee75f36836/third_party/WebKit/LayoutTests/virtual/color_space/fast/canvas/color-space/README.txt [add] https://crrev.com/1837b16f64c579bc60b2e3ae512de9ee75f36836/third_party/WebKit/LayoutTests/virtual/color_space/fast/canvas/color-space/canvas-colorSpace-attribute.html [modify] https://crrev.com/1837b16f64c579bc60b2e3ae512de9ee75f36836/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp
,
Nov 23 2016
,
Nov 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7bf0f77ad5b4b7413ca1e11ed9683983239bc2f2 commit 7bf0f77ad5b4b7413ca1e11ed9683983239bc2f2 Author: zakerinasab <zakerinasab@chromium.org> Date: Wed Nov 30 08:04:20 2016 Removing self.Fails of browser pixel tests from pixel_expectations.py. As all the results on cloud storage bucket are as expected, we can remove the self.Fails lines from pixel_expectations.py. BUG= 657946 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2532603002 Cr-Commit-Position: refs/heads/master@{#435152} [modify] https://crrev.com/7bf0f77ad5b4b7413ca1e11ed9683983239bc2f2/content/test/gpu/gpu_tests/pixel_expectations.py
,
Dec 2 2016
,
Dec 4 2016
,
Dec 16 2016
Issue 649419 has been merged into this issue. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by junov@chromium.org
, Oct 20 2016