New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 657945 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug
Team-Accessibility

Blocking:
issue 462133


Participants' hotlists:
MacViews-Task-Queue


Sign in to add a comment

MacViews(a11y): Not possible to explore a label word-by-word with VO

Project Member Reported by sdy@chromium.org, Oct 20 2016

Issue description

Version: 56.0.2896.0
OS: 10.12

What steps will reproduce the problem?
(1) Find a MacViews label (e.g. in the origin info bubble)
(2) VO+shift+down to interact with it.
(3) VO+arrows to move around.

What is the expected output?
VO announces, "in text: <text>". It's then possible to use VO+arrows to explore the text word-by-word.

What do you see instead?
VO announces "in text". VO+arrows does nothing (just plays the "nowhere to go" chime).
 
Status: Available (was: Untriaged)

Comment 2 by tapted@chromium.org, Dec 12 2016

Blocking: 462133
Owner: patricia...@chromium.org
Status: Assigned (was: Available)
patricialor@: can you take a look please? it sounds like we probably need some wiring...
Labels: NewComponent-Accessibility NewComponent-Accessibility-Compatibility
Labels: -M-56 MacViews-Dialogs
patricialor@, can you take a peek at this? I'm not sure how complicated it will be.
Components: UI>Accessibility>Compatibility
Components: -UI>Accessibility
Labels: -newcomponent-accessibility-compatibility -newcomponent-accessibility

Comment 8 by tapted@chromium.org, Jun 13 2017

Cc: patricia...@chromium.org
Owner: tapted@chromium.org
Status: Started (was: Assigned)
https://codereview.chromium.org/2934993002
Thanks for grabbing this, tapted@ :)
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a523016fb1f4607afe920e467b73d2ff6473d5f1

commit a523016fb1f4607afe920e467b73d2ff6473d5f1
Author: tapted <tapted@chromium.org>
Date: Thu Jun 15 02:03:20 2017

MacViews a11y: Allow VoiceOver to read out views::Label word-by-word.

This requires the label to respond to AXValue, not just AXTitle.
views::Label currently reports nil for its AXValue. Cocoa labels are
just readonly NSTextFields, so they have AXValue.

Fix by sharing more responders used for text fields currently. This
brought in to question the behaviour for secure text fields, which
appears to have changed in macOS. Get the shared code up to speed with
current behavior.

BUG= 657945 

Review-Url: https://codereview.chromium.org/2934993002
Cr-Commit-Position: refs/heads/master@{#479582}

[modify] https://crrev.com/a523016fb1f4607afe920e467b73d2ff6473d5f1/ui/accessibility/platform/ax_platform_node_mac.mm
[modify] https://crrev.com/a523016fb1f4607afe920e467b73d2ff6473d5f1/ui/views/controls/textfield/textfield.cc
[modify] https://crrev.com/a523016fb1f4607afe920e467b73d2ff6473d5f1/ui/views/controls/textfield/textfield_unittest.cc
[modify] https://crrev.com/a523016fb1f4607afe920e467b73d2ff6473d5f1/ui/views/widget/native_widget_mac_accessibility_unittest.mm

Status: Fixed (was: Started)
This specifically is fixed, but there's more to do in  Issue 657884  which, for example, will provide visual feedback by highlighting each word as it's read out.
wordbyword.mp4
3.4 MB View Download

Sign in to add a comment